Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate deprecated attributes from static traversals #31576

Merged
merged 1 commit into from Aug 9, 2022

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Aug 4, 2022

We can't validate if data from deprecated nested attributes is not used in the configuration, but we can at least catch the simple case where a deprecated attribute is referenced directly.

Partial fix for #7569

We can't validate that data from deprecated nested attributes is used in
the configuration, but we can at least catch the simple case where a
deprecated attribute is referenced directly.
@jbardin jbardin force-pushed the jbardin/validate-deprecated-computed branch from d15a12f to 25f5a81 Compare August 8, 2022 13:58
@jbardin jbardin added the 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Aug 9, 2022
Base automatically changed from jbardin/static-validate-nested-types to main August 9, 2022 15:08
@jbardin jbardin merged commit 8354bc4 into main Aug 9, 2022
@jbardin jbardin deleted the jbardin/validate-deprecated-computed branch August 9, 2022 15:10
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants