Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect PR link in beta release notes #31716

Closed
dancorne opened this issue Aug 31, 2022 · 3 comments
Closed

Incorrect PR link in beta release notes #31716

dancorne opened this issue Aug 31, 2022 · 3 comments
Labels
bug new new issue not yet triaged

Comments

@dancorne
Copy link

Terraform Version

1.3.0-beta1

Terraform Configuration Files

N/A

Debug Output

N/A

Expected Behavior

Link to this PR should be in release notes: #31687

Actual Behavior

The following PR is actually linked: #31154

Steps to Reproduce

See https://github.com/hashicorp/terraform/releases/tag/v1.3.0-beta1, second point under Enhancements

Additional Context

Hello, not sure if Github Issues is the best place to let you know, sorry if there's a better avenue for this...

Very minor thing, but looks like there's an incorrect link in the new beta Terraform 1.3.0-beta1 release notes. Maybe a copy/paste error? Currently under Enhancements:

config: Optional attributes for object type constraints, as described under new features above. (#31154)
config: New built-in function timecmp allows determining the ordering relationship between two timestamps while taking potentially-different UTC offsets into account. (#31154)

I think that second PR link should probably be #31687

References

No response

@dancorne dancorne added bug new new issue not yet triaged labels Aug 31, 2022
@crw
Copy link
Collaborator

crw commented Aug 31, 2022

Thanks for the report! I let the team know.

@kmoe
Copy link
Member

kmoe commented Aug 31, 2022

Thank you for letting us know. I'm impressed you noticed this so quickly. I've updated both the GitHub Release notes and the changelog on the appropriate release branch, so the changelog for (subsequent prereleases and) the final v1.3.0 release will be correct.

@kmoe kmoe closed this as completed Aug 31, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug new new issue not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants