Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune unused nodes from a destroy plan graph #31858

Merged
merged 1 commit into from Sep 26, 2022
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Sep 23, 2022

We may need to prune nodes from a full destroy plan graph which cannot be evaluated if there is no current state. This is the same method used during apply, however for planning we are only going to encounter evaluation problems during a full destroy, so we can skip the pruning process for normal plans.

Add missing expandsInstances() method to nodeExpandPlannableResource to ensure planned resources are handled correctly when pruning nodes.

Fixes #31838

We may need to prune nodes from a full destroy plan graph which cannot
be evaluated if there is no current state.

Add missing method to nodeExpandPlannableResource to ensure planned
resource are handled correctly when pruning nodes.
@jbardin jbardin added the 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Sep 23, 2022
@jbardin jbardin requested a review from a team September 23, 2022 19:08
@jbardin jbardin self-assigned this Sep 23, 2022
@apparentlymart apparentlymart added this to the v1.3.1 milestone Sep 26, 2022
@jbardin jbardin merged commit 008810f into main Sep 26, 2022
@jbardin jbardin deleted the jbardin/prune-plan-destroy branch September 26, 2022 18:24
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty destroy fails on conditional modules
3 participants