Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quiet value #32116

Merged
merged 4 commits into from Jan 25, 2023
Merged

Added Quiet value #32116

merged 4 commits into from Jan 25, 2023

Conversation

itspooya
Copy link
Contributor

Added Quiet value in order to quiet the output from local-exec

Fixes #32097

Target Release

1.4.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 29, 2022

CLA assistant check
All committers have signed the CLA.

@crw crw added the enhancement label Nov 1, 2022
@crw
Copy link
Collaborator

crw commented Nov 1, 2022

Thanks for this submission. Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it. Thanks again for the submission!

@itspooya
Copy link
Contributor Author

itspooya commented Nov 4, 2022

Thank you @crw

@itspooya
Copy link
Contributor Author

itspooya commented Nov 7, 2022

@crw
Hi
Is there anything I can do about this PR?
I wanted to send some other PRs too
Thank you

@crw crw assigned kmoe Nov 7, 2022
@crw
Copy link
Collaborator

crw commented Nov 7, 2022

@itspooya Thanks, we are running it by the team. If it looks OK to accept, then there may be changes requested during review.

With regards to other PRs, just be mindful of our contributing guidelines, particularly: https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md#proposing-a-change. Your PRs are more likely to be accepted if the solution has already been discussed in the Github issue you are attempting to close. Thanks!

@itspooya
Copy link
Contributor Author

itspooya commented Nov 8, 2022

@crw Thanks, I am looking forward to improve and being mindful of your contributing guidelines
Also I had a question regarding Vercel and how to authorize to fix the tests
Best Regards
Pooya

@crw
Copy link
Collaborator

crw commented Nov 9, 2022

Also I had a question regarding Vercel and how to authorize to fix the tests

There has been some confusion about this; basically before merging a HashiCorp employee can authorize the test to run successfully. It is only needed for a documentation change. Thanks!

@itspooya
Copy link
Contributor Author

@crw
Hey I just wanted to check whether this pull request would be merged or not?

@crw
Copy link
Collaborator

crw commented Jan 19, 2023

@itspooya This one seems to have got lost in the shuffle. Let me follow up with the team and get back to you.

Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One minor change.

@itspooya
Copy link
Contributor Author

@kmoe
Please check it, Thanks

@itspooya
Copy link
Contributor Author

@crw
Hello, could you check it please?
Thanks

@crw
Copy link
Collaborator

crw commented Jan 24, 2023

It is being discussed by the team. I will see if there is a resolution.

@kmoe kmoe merged commit 6bbb76e into hashicorp:main Jan 25, 2023
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a quiet mode for local-exec
4 participants