Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/oss: Ignore the getting oss endpoint error and using string concat instead; Improves the error message level #32295

Merged
merged 1 commit into from Dec 5, 2022

Conversation

xiaozhu36
Copy link
Contributor

This PR aims to fix getting oss endpoint error caused by network connection failed and other reasons. This error will break oss backend process. Considering all of oss endpoints have followed up pattern oss-<RegionId>.aliyuncs.com, above error can be ignored.

Fixes #

Target Release

1.4.x

Draft CHANGELOG entry

ENHANCEMENTS

  • backend/oss: Ignore the getting oss endpoint error and using string concat instead; Improves the error message level

@crw
Copy link
Collaborator

crw commented Nov 30, 2022

Thanks for this submission, I'll notify the core team.

Copy link
Member

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this if you can fix the gofmt error! Please run gofmt on these files and push a new commit.

internal/backend/remote-state/oss/backend.go Outdated Show resolved Hide resolved
…oncat instead; Improves the error message level
Copy link
Member

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alisdair alisdair merged commit 80fddc4 into hashicorp:main Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants