Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GCS backend specific env var for impersonation #32557

Merged
merged 1 commit into from Feb 9, 2023

Conversation

bharathkkb
Copy link
Contributor

Fixes #32556

Target Release

1.4.x

Draft CHANGELOG entry

ENHANCEMENTS

  • Added support for GOOGLE_BACKEND_IMPERSONATE_SERVICE_ACCOUNT env var to allow impersonating a different service account when GOOGLE_IMPERSONATE_SERVICE_ACCOUNT is configured for the GCP provider.

@bharathkkb bharathkkb requested a review from a team as a code owner January 21, 2023 05:41
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 21, 2023

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Collaborator

crw commented Jan 24, 2023

Thanks for this submission. I've notified the Google Provider team for review.

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@megan07 megan07 merged commit d7d8a22 into hashicorp:main Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

liamcervante pushed a commit that referenced this pull request Feb 10, 2023
Add a GCS backend specific env var for impersonation
liamcervante added a commit that referenced this pull request Feb 10, 2023
…var (#32657)

Add a GCS backend specific env var for impersonation

Co-authored-by: megan07 <mbang@hashicorp.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GCS backend specific env var for impersonation
4 participants