Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save null module outputs in state #32583

Merged
merged 1 commit into from Jan 26, 2023
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Jan 26, 2023

Although they are not serialized to the final stored state, all module outputs must be saved in the state for evaluation. There is no defined schema which is used to identify the overall type of module outputs, so all outputs must exist in the state to build the correct type for proper evaluation.

A corresponding change will be backported to v1.3 manually, since this commit overlaps with conflicting changes in main.

Although they are not serialized to the final stored state, all module
outputs must be saved in the state for evaluation. There is no defined
schema which is used to identify the overall type of module outputs, so
all outputs must exist in the state to build the correct type for proper
evaluation.
@jbardin jbardin merged commit fc8fed0 into main Jan 26, 2023
@jbardin jbardin deleted the jbardin/store-null-module-outputs branch January 26, 2023 20:35
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@ronmjf
Copy link

ronmjf commented Feb 14, 2023

Hi, is that fix lead to the following behavior changes?
in 1.2.9 when we apply and then destroy without having resources a new state will create, in the new version in such case there is no new state creation.

@alisdair
Copy link
Member

Hi @ronmjf. I can't follow what you're asking here. Could you please file a bug report with a detailed reproduction so that we can investigate further?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants