Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of bugfix: terraform providers mirror command should honor terraform lock file into v1.4 #32749

Conversation

teamterraform
Copy link
Contributor

@teamterraform teamterraform commented Feb 27, 2023

Backport

This PR is auto-generated from #32742 to be assessed for backporting due to the inclusion of the label 1.4-backport.

The below text is copied from the body of the original PR.


When mirroring providers using terraform providers mirror command, AND, if dependency lock file exists, selected provider version might not match the dependency lock file.

So, this PR addresses this issue by honouring the lock file if present.

A new e2e test case has been added to cover this new case.

Fixes #28274

Target Release

1.4.1

Draft CHANGELOG entry

BUG FIXES

  • terraform providers mirror: support dependency lock file

@teamterraform teamterraform force-pushed the backport/bugfix/issue-28274-providers-mirroring-honor-lockfile/legally-upright-mastiff branch from 7591ce8 to 1c7700f Compare February 27, 2023 15:03
@alisdair alisdair requested a review from a team February 27, 2023 15:03
@alisdair alisdair self-assigned this Feb 27, 2023
@alisdair
Copy link
Member

Proposing for 1.4.1.

@alisdair alisdair merged commit 680b303 into v1.4 Mar 9, 2023
@alisdair alisdair deleted the backport/bugfix/issue-28274-providers-mirroring-honor-lockfile/legally-upright-mastiff branch March 9, 2023 13:20
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants