Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent nil Colorize options when rendering state outputs #32840

Merged
merged 2 commits into from Mar 14, 2023
Merged

Prevent nil Colorize options when rendering state outputs #32840

merged 2 commits into from Mar 14, 2023

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Mar 14, 2023

When rendering nested nil output values from state, the Colorize options could be set to nil. Ensure the RenderHumanOpts are always instantiated via their constructor. If a constructor is required, it would probably be safer to have no exported fields for the type, but that level of refactoring will have to be review separately.

Fixes #32833

Target Release

v1.4.1

@jbardin jbardin added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Mar 14, 2023
@jbardin jbardin requested a review from a team March 14, 2023 14:11
@jbardin jbardin changed the title PreventFix nil Colorize options when rendering state outputs Prevent nil Colorize options when rendering state outputs Mar 14, 2023
apparentlymart
apparentlymart approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Agreed about switching this to use unexported fields and an explicit API for construction, modification, and usage, but also agreed that it should be a separate change.

@jbardin jbardin merged commit ccb376a into main Mar 14, 2023
@jbardin jbardin deleted the jbardin/render-output-crash branch March 14, 2023 18:28
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Mar 14, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apparentlymart apparentlymart apparentlymart approved these changes

Assignees
No one assigned
Labels
1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TERRAFORM CRASH: runtime error: invalid memory address or nil pointer dereference
2 participants
@jbardin @apparentlymart