Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cty minor version v1.13 upgrade #32860

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

apparentlymart
Copy link
Member

We inadvertently incorporated the new minor release of cty into the 1.4 branch, and that's introduced some more refined handling of unknown values that is too much of a change to introduce in a patch release.

Therefore this reverts back to the previous minor release for the v1.4 series, and then we'll separately get the main branch ready to work correctly with the new cty before Terraform v1.5.

This reverts just the upgrade and the corresponding test changes from #32775, while retaining the HCL upgrade and the new test case it introduced for that bug it was trying to fix. That new test is still passing so it seems that the cty upgrade is not crucial to that fix.

@apparentlymart apparentlymart requested a review from a team March 15, 2023 23:15
@apparentlymart apparentlymart self-assigned this Mar 15, 2023
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 15, 2023

CLA assistant check
All committers have signed the CLA.

We inadvertently incorporated the new minor release of cty into the 1.4
branch, and that's introduced some more refined handling of unknown values
that is too much of a change to introduce in a patch release.

Therefore this reverts back to the previous minor release for the v1.4
series, and then we'll separately get the main branch ready to work
correctly with the new cty before Terraform v1.5.

This reverts just the upgrade and the corresponding test changes from
#32775, while retaining the HCL upgrade and the new test case it
introduced for that bug it was trying to fix. That new test is still
passing so it seems that the cty upgrade is not crucial to that fix.
@apparentlymart
Copy link
Member Author

This might repair #32853, but not clear yet because we've not reproduced that one to determine how a non-collection type is ending up in the setproduct function.

@jbardin
Copy link
Member

jbardin commented Mar 16, 2023

I can confirm the change fixes 32853. Not certain what is going on exactly, but a DynamicPseudoType being passed into the impl as the return type, which panics when we fetch the element type.

@kmoe kmoe merged commit 7938147 into v1.4 Mar 16, 2023
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants