From e777d3b4edb4f82b2911585c3743f56fc0390080 Mon Sep 17 00:00:00 2001 From: Austin Gebauer <34121980+austingebauer@users.noreply.github.com> Date: Mon, 25 Oct 2021 10:57:26 -0700 Subject: [PATCH] Adds missing unlock of RWMutex in OIDC delete key (#12916) (#12922) --- changelog/12916.txt | 3 +++ vault/identity_store_oidc.go | 1 + 2 files changed, 4 insertions(+) create mode 100644 changelog/12916.txt diff --git a/changelog/12916.txt b/changelog/12916.txt new file mode 100644 index 0000000000000..8d75b39230a6d --- /dev/null +++ b/changelog/12916.txt @@ -0,0 +1,3 @@ +```release-note:bug +identity/token: Adds missing call to unlock mutex in key deletion error handling +``` diff --git a/vault/identity_store_oidc.go b/vault/identity_store_oidc.go index bc865d15a610b..8bd393873b2bd 100644 --- a/vault/identity_store_oidc.go +++ b/vault/identity_store_oidc.go @@ -634,6 +634,7 @@ func (i *IdentityStore) pathOIDCDeleteKey(ctx context.Context, req *logical.Requ roleNames, err := i.roleNamesReferencingTargetKeyName(ctx, req, targetKeyName) if err != nil { + i.oidcLock.Unlock() return nil, err }