Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google OAUTH2 to support Workload Identity Federation #11255

Closed
prashantkul opened this issue Mar 31, 2021 · 6 comments
Closed

Update google OAUTH2 to support Workload Identity Federation #11255

prashantkul opened this issue Mar 31, 2021 · 6 comments
Labels
auth/gcp dependencies Pull requests that update a dependency file ecosystem enhancement

Comments

@prashantkul
Copy link

Please update google OAUTH2 library to support Workload Identity Federation.

GO v0.0.0-20210218202405-ba52d332ba99 or later of the golang.org/x/oauth2 module

@calvn
Copy link
Member

calvn commented May 24, 2021

Hello, thanks for opening a GH issue on this request! There's an ongoing dependency issue where both the golang.org/x/oauth2 package and the github.com/etcd-io/etcd package depends on google.golang.org/grpc, and upgrading the former breaks the latter due to package incompatibility issues, thus breaking the Vault build.

We're looking into updating the etcd depending to be at etcd v3.5.0-alpha.0 or newer which might unblock us from this dependency problem, but we'll have to make additional code changes to get the imports and references updated throughout the codebase.

Related to etcd-io/etcd#12124
Similar to hashicorp/cap#14

@MXfive
Copy link

MXfive commented Feb 17, 2022

Seems this is unblocked now, would be really great for cloud portable workloads to run on both clouds simultaneously using Vault to provision credentials.

@prashantkul
Copy link
Author

prashantkul commented Feb 17, 2022 via email

@hsimon-hashicorp hsimon-hashicorp added dependencies Pull requests that update a dependency file auth/gcp labels Feb 22, 2022
@austingebauer
Copy link
Member

@prashantkul - We've recently upgraded our golang.org/x/oauth2 dependency beyond the version you've suggested in this issue. Are you able to provide any additional information as to how this specific dependency upgrade would help us support Workload Identity Federation? Thank you!

@sofixa
Copy link
Contributor

sofixa commented May 5, 2022

I can confirm that Vault now supports GCP Workload Identity Federation and can successfully auth into GCP from other trusted identity providers.

@hsimon-hashicorp
Copy link
Contributor

Thank you, @sofixa - I will close this issue now, but folks can feel free to re-open it as needed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth/gcp dependencies Pull requests that update a dependency file ecosystem enhancement
Projects
None yet
Development

No branches or pull requests

7 participants