From ac23e1be6ec4da0d8ba47e59564c2bf13c874147 Mon Sep 17 00:00:00 2001 From: Arnav Palnitkar Date: Wed, 15 Sep 2021 00:19:33 -0700 Subject: [PATCH 1/5] Client count updates - Added Current month tab which leverages partial monthly activity api - Refactored Vault usage to Monthly history - New client count history component based on StatText and BarChart component - Restrict bar chart to showcase only top 10 namespaces - Removed config route, as config and history component will be rendered based on query param - Updated all metrics reference to clients - Removed old tests and added integration test for current month --- .../adapters/{metrics => clients}/activity.js | 6 +- .../adapters/{metrics => clients}/config.js | 0 .../config.js} | 12 +- ui/app/components/clients/history.js | 26 +++++ ui/app/components/pricing-metrics-dates.js | 42 +------ .../vault/cluster/clients/index.js | 8 ++ .../vault/cluster/metrics/index.js | 8 -- .../models/{metrics => clients}/activity.js | 1 + ui/app/models/{metrics => clients}/config.js | 0 ui/app/router.js | 3 +- .../cluster/{metrics => clients}/edit.js | 2 +- .../cluster/{metrics => clients}/index.js | 37 +++--- ui/app/routes/vault/cluster/metrics/config.js | 8 -- .../{metrics => clients}/activity.js | 0 .../{metrics => clients}/config.js | 0 ui/app/services/permissions.js | 2 +- ui/app/styles/components/bar-chart.scss | 5 +- ui/app/styles/components/stat-text.scss | 4 + .../config.hbs} | 3 +- .../templates/components/clients/history.hbs | 94 ++++++++++++++++ ui/app/templates/components/cluster-info.hbs | 6 +- .../components/pricing-metrics-dates.hbs | 10 -- .../cluster/{metrics => clients}/edit.hbs | 2 +- .../templates/vault/cluster/clients/index.hbs | 47 ++++++++ .../vault/cluster/metrics/config.hbs | 36 ------ .../templates/vault/cluster/metrics/index.hbs | 78 ------------- ui/lib/core/addon/components/bar-chart.js | 8 +- ui/mirage/config.js | 4 +- ui/mirage/scenarios/default.js | 2 +- ui/tests/acceptance/usage-metrics-test.js | 106 ------------------ ...-config-test.js => clients-config-test.js} | 12 +- .../components/clients-current-test.js | 57 ++++++++++ .../components/clients-history-test.js | 67 +++++++++++ .../components/pricing-metrics-dates-test.js | 28 ----- 34 files changed, 362 insertions(+), 362 deletions(-) rename ui/app/adapters/{metrics => clients}/activity.js (77%) rename ui/app/adapters/{metrics => clients}/config.js (100%) rename ui/app/components/{pricing-metrics-config.js => clients/config.js} (82%) create mode 100644 ui/app/components/clients/history.js create mode 100644 ui/app/controllers/vault/cluster/clients/index.js delete mode 100644 ui/app/controllers/vault/cluster/metrics/index.js rename ui/app/models/{metrics => clients}/activity.js (84%) rename ui/app/models/{metrics => clients}/config.js (100%) rename ui/app/routes/vault/cluster/{metrics => clients}/edit.js (62%) rename ui/app/routes/vault/cluster/{metrics => clients}/index.js (51%) delete mode 100644 ui/app/routes/vault/cluster/metrics/config.js rename ui/app/serializers/{metrics => clients}/activity.js (100%) rename ui/app/serializers/{metrics => clients}/config.js (100%) rename ui/app/templates/components/{pricing-metrics-config.hbs => clients/config.hbs} (98%) create mode 100644 ui/app/templates/components/clients/history.hbs rename ui/app/templates/vault/cluster/{metrics => clients}/edit.hbs (71%) create mode 100644 ui/app/templates/vault/cluster/clients/index.hbs delete mode 100644 ui/app/templates/vault/cluster/metrics/config.hbs delete mode 100644 ui/app/templates/vault/cluster/metrics/index.hbs delete mode 100644 ui/tests/acceptance/usage-metrics-test.js rename ui/tests/integration/components/{pricing-metrics-config-test.js => clients-config-test.js} (91%) create mode 100644 ui/tests/integration/components/clients-current-test.js create mode 100644 ui/tests/integration/components/clients-history-test.js diff --git a/ui/app/adapters/metrics/activity.js b/ui/app/adapters/clients/activity.js similarity index 77% rename from ui/app/adapters/metrics/activity.js rename to ui/app/adapters/clients/activity.js index 09ea312b030e5..df54b0ea449fd 100644 --- a/ui/app/adapters/metrics/activity.js +++ b/ui/app/adapters/clients/activity.js @@ -5,7 +5,11 @@ export default Application.extend({ return 'internal/counters/activity'; }, queryRecord(store, type, query) { - const url = this.urlForQuery(null, type); + let url = this.urlForQuery(null, type); + if (query.tab === 'current') { + url = `${url}/monthly`; + query = null; + } // API accepts start and end as query params return this.ajax(url, 'GET', { data: query }).then(resp => { let response = resp || {}; diff --git a/ui/app/adapters/metrics/config.js b/ui/app/adapters/clients/config.js similarity index 100% rename from ui/app/adapters/metrics/config.js rename to ui/app/adapters/clients/config.js diff --git a/ui/app/components/pricing-metrics-config.js b/ui/app/components/clients/config.js similarity index 82% rename from ui/app/components/pricing-metrics-config.js rename to ui/app/components/clients/config.js index a61ef3d3420cf..9b093ecae603c 100644 --- a/ui/app/components/pricing-metrics-config.js +++ b/ui/app/components/clients/config.js @@ -1,12 +1,12 @@ /** - * @module PricingMetricsConfig - * PricingMetricsConfig components are used to show and edit the pricing metrics config information. + * @module ClientsConfig + * ClientsConfig components are used to show and edit the client count config information. * * @example * ```js - * + * * ``` - * @param {object} model - model is the DS metrics/config model which should be passed in + * @param {object} model - model is the DS clients/config model which should be passed in * @param {string} [mode=show] - mode is either show or edit. Show results in a table with the config, show has a form. */ @@ -16,7 +16,7 @@ import { inject as service } from '@ember/service'; import { tracked } from '@glimmer/tracking'; import { task } from 'ember-concurrency'; -export default class PricingMetricsConfigComponent extends Component { +export default class ConfigComponent extends Component { @service router; @tracked mode = 'show'; @tracked modalOpen = false; @@ -57,7 +57,7 @@ export default class PricingMetricsConfigComponent extends Component { this.error = err.message; return; } - this.router.transitionTo('vault.cluster.metrics.config'); + this.router.transitionTo('vault.cluster.clients.index'); }).drop()) save; diff --git a/ui/app/components/clients/history.js b/ui/app/components/clients/history.js new file mode 100644 index 0000000000000..6a71ed6da5e9e --- /dev/null +++ b/ui/app/components/clients/history.js @@ -0,0 +1,26 @@ +import Component from '@glimmer/component'; + +export default class HistoryComponent extends Component { + max_namespaces = 10; + + get dataset() { + if (!this.args.model.activity || !this.args.model.activity.byNamespace) { + return null; + } + let dataset = this.args.model.activity.byNamespace; + // Filter out root data + dataset = dataset.filter(item => { + return item.namespace_id != 'root'; + }); + // Show only top 10 namespaces + dataset = dataset.slice(0, this.max_namespaces); + return dataset.map(d => { + return { + label: d['namespace_path'], + non_entity_tokens: d['counts']['non_entity_tokens'], + distinct_entities: d['counts']['distinct_entities'], + total: d['counts']['clients'], + }; + }); + } +} diff --git a/ui/app/components/pricing-metrics-dates.js b/ui/app/components/pricing-metrics-dates.js index 2189ae0f8f438..0cc7a3b7653bd 100644 --- a/ui/app/components/pricing-metrics-dates.js +++ b/ui/app/components/pricing-metrics-dates.js @@ -18,16 +18,7 @@ import { set, computed } from '@ember/object'; import { inject as service } from '@ember/service'; import Component from '@ember/component'; -import { - differenceInSeconds, - isValid, - subMonths, - startOfToday, - format, - endOfMonth, - startOfMonth, - isBefore, -} from 'date-fns'; +import { subMonths, startOfToday, format, endOfMonth, startOfMonth, isBefore } from 'date-fns'; import layout from '../templates/components/pricing-metrics-dates'; import { parseDateString } from 'vault/helpers/parse-date-string'; @@ -69,35 +60,6 @@ export default Component.extend({ } }), - // We don't want the warning to show when inputs are being updated before query is made - /* eslint-disable-next-line ember/require-computed-property-dependencies */ - showResultsWarning: computed('resultEnd', 'resultStart', function() { - if (!this.queryStart || !this.queryEnd || !this.resultStart || !this.resultEnd) { - return false; - } - const resultStart = new Date(this.resultStart); - const resultEnd = new Date(this.resultEnd); - let queryStart, queryEnd; - try { - queryStart = parseDateString(this.queryStart, '-'); - queryEnd = parseDateString(this.queryEnd, '-'); - } catch (e) { - // Log error for debugging purposes - console.debug(e); - } - - if (!queryStart || !queryEnd || !isValid(resultStart) || !isValid(resultEnd)) { - return false; - } - if (Math.abs(differenceInSeconds(queryStart, resultStart)) >= 86400) { - return true; - } - if (Math.abs(differenceInSeconds(resultEnd, endOfMonth(queryEnd))) >= 86400) { - return true; - } - return false; - }), - error: computed('end', 'endDate', 'retentionMonths', 'start', 'startDate', function() { if (!this.startDate) { return 'Start date is invalid. Please use format MM/yyyy'; @@ -148,7 +110,7 @@ export default Component.extend({ handleQuery() { const start = format(this.startDate, 'MM-yyyy'); const end = format(this.endDate, 'MM-yyyy'); - this.router.transitionTo('vault.cluster.metrics', { + this.router.transitionTo('vault.cluster.clients', { queryParams: { start, end, diff --git a/ui/app/controllers/vault/cluster/clients/index.js b/ui/app/controllers/vault/cluster/clients/index.js new file mode 100644 index 0000000000000..8cb0262e7f832 --- /dev/null +++ b/ui/app/controllers/vault/cluster/clients/index.js @@ -0,0 +1,8 @@ +import Controller from '@ember/controller'; + +export default class ClientsController extends Controller { + queryParams = ['tab', 'start', 'end']; + tab = null; + start = null; + end = null; +} diff --git a/ui/app/controllers/vault/cluster/metrics/index.js b/ui/app/controllers/vault/cluster/metrics/index.js deleted file mode 100644 index e355af5b80848..0000000000000 --- a/ui/app/controllers/vault/cluster/metrics/index.js +++ /dev/null @@ -1,8 +0,0 @@ -import Controller from '@ember/controller'; - -export default Controller.extend({ - queryParams: ['start', 'end'], - - start: null, - end: null, -}); diff --git a/ui/app/models/metrics/activity.js b/ui/app/models/clients/activity.js similarity index 84% rename from ui/app/models/metrics/activity.js rename to ui/app/models/clients/activity.js index d220bf184ad30..ba88d9839d91a 100644 --- a/ui/app/models/metrics/activity.js +++ b/ui/app/models/clients/activity.js @@ -2,6 +2,7 @@ import Model, { attr } from '@ember-data/model'; export default Model.extend({ total: attr('object'), + byNamespace: attr('array'), endTime: attr('string'), startTime: attr('string'), }); diff --git a/ui/app/models/metrics/config.js b/ui/app/models/clients/config.js similarity index 100% rename from ui/app/models/metrics/config.js rename to ui/app/models/clients/config.js diff --git a/ui/app/router.js b/ui/app/router.js index ee964bfb77ac5..090def1fa2acc 100644 --- a/ui/app/router.js +++ b/ui/app/router.js @@ -15,9 +15,8 @@ Router.map(function() { this.route('logout'); this.mount('open-api-explorer', { path: '/api-explorer' }); this.route('license'); - this.route('metrics', function() { + this.route('clients', function() { this.route('index', { path: '/' }); - this.route('config'); this.route('edit'); }); this.route('storage', { path: '/storage/raft' }); diff --git a/ui/app/routes/vault/cluster/metrics/edit.js b/ui/app/routes/vault/cluster/clients/edit.js similarity index 62% rename from ui/app/routes/vault/cluster/metrics/edit.js rename to ui/app/routes/vault/cluster/clients/edit.js index ddb4f482a2157..51f0bb9b86c43 100644 --- a/ui/app/routes/vault/cluster/metrics/edit.js +++ b/ui/app/routes/vault/cluster/clients/edit.js @@ -2,6 +2,6 @@ import Route from '@ember/routing/route'; export default Route.extend({ model() { - return this.store.queryRecord('metrics/config', {}); + return this.store.queryRecord('clients/config', {}); }, }); diff --git a/ui/app/routes/vault/cluster/metrics/index.js b/ui/app/routes/vault/cluster/clients/index.js similarity index 51% rename from ui/app/routes/vault/cluster/metrics/index.js rename to ui/app/routes/vault/cluster/clients/index.js index 59e7b5a3cd9cd..b08d01e0783ce 100644 --- a/ui/app/routes/vault/cluster/metrics/index.js +++ b/ui/app/routes/vault/cluster/clients/index.js @@ -4,23 +4,27 @@ import { hash } from 'rsvp'; import { getTime } from 'date-fns'; import { parseDateString } from 'vault/helpers/parse-date-string'; -const getActivityParams = ({ start, end }) => { +const getActivityParams = ({ tab, start, end }) => { // Expects MM-yyyy format // TODO: minStart, maxEnd let params = {}; - if (start) { - let startDate = parseDateString(start); - if (startDate) { - // TODO: Replace with formatRFC3339 when date-fns is updated - // converts to milliseconds, divide by 1000 to get epoch - params.start_time = getTime(startDate) / 1000; + if (tab === 'current') { + params.tab = tab; + } else if (tab === 'history') { + if (start) { + let startDate = parseDateString(start); + if (startDate) { + // TODO: Replace with formatRFC3339 when date-fns is updated + // converts to milliseconds, divide by 1000 to get epoch + params.start_time = getTime(startDate) / 1000; + } } - } - if (end) { - let endDate = parseDateString(end); - if (endDate) { - // TODO: Replace with formatRFC3339 when date-fns is updated - params.end_time = getTime(endDate) / 1000; + if (end) { + let endDate = parseDateString(end); + if (endDate) { + // TODO: Replace with formatRFC3339 when date-fns is updated + params.end_time = getTime(endDate) / 1000; + } } } return params; @@ -28,6 +32,9 @@ const getActivityParams = ({ start, end }) => { export default Route.extend(ClusterRoute, { queryParams: { + tab: { + refreshModel: true, + }, start: { refreshModel: true, }, @@ -37,13 +44,13 @@ export default Route.extend(ClusterRoute, { }, model(params) { - let config = this.store.queryRecord('metrics/config', {}).catch(e => { + let config = this.store.queryRecord('clients/config', {}).catch(e => { console.debug(e); // swallowing error so activity can show if no config permissions return {}; }); const activityParams = getActivityParams(params); - let activity = this.store.queryRecord('metrics/activity', activityParams); + let activity = this.store.queryRecord('clients/activity', activityParams); return hash({ queryStart: params.start, diff --git a/ui/app/routes/vault/cluster/metrics/config.js b/ui/app/routes/vault/cluster/metrics/config.js deleted file mode 100644 index ed1a32d5e4e44..0000000000000 --- a/ui/app/routes/vault/cluster/metrics/config.js +++ /dev/null @@ -1,8 +0,0 @@ -import Route from '@ember/routing/route'; -import ClusterRoute from 'vault/mixins/cluster-route'; - -export default Route.extend(ClusterRoute, { - model() { - return this.store.queryRecord('metrics/config', {}); - }, -}); diff --git a/ui/app/serializers/metrics/activity.js b/ui/app/serializers/clients/activity.js similarity index 100% rename from ui/app/serializers/metrics/activity.js rename to ui/app/serializers/clients/activity.js diff --git a/ui/app/serializers/metrics/config.js b/ui/app/serializers/clients/config.js similarity index 100% rename from ui/app/serializers/metrics/config.js rename to ui/app/serializers/clients/config.js diff --git a/ui/app/services/permissions.js b/ui/app/services/permissions.js index c58bb3f39317e..aa67e2128ce73 100644 --- a/ui/app/services/permissions.js +++ b/ui/app/services/permissions.js @@ -29,7 +29,7 @@ const API_PATHS = { seal: 'sys/seal', raft: 'sys/storage/raft/configuration', }, - metrics: { + clients: { activity: 'sys/internal/counters/activity', config: 'sys/internal/counters/config', }, diff --git a/ui/app/styles/components/bar-chart.scss b/ui/app/styles/components/bar-chart.scss index 1cc9bc12689e8..44458d04c58cc 100644 --- a/ui/app/styles/components/bar-chart.scss +++ b/ui/app/styles/components/bar-chart.scss @@ -7,14 +7,11 @@ > div.is-border { border: 0.3px solid $ui-gray-200; - width: 94%; - margin-left: 3%; margin-bottom: $spacing-xxs; } } .chart-header { - margin-left: $spacing-l; display: grid; grid-template-columns: 3fr 1fr; @@ -47,7 +44,7 @@ } .bar-chart-container { - padding: $spacing-m $spacing-l $spacing-m $spacing-l; + padding: $spacing-m 0; } .bar-chart { diff --git a/ui/app/styles/components/stat-text.scss b/ui/app/styles/components/stat-text.scss index 814d8a87bedb1..efd76fa62140a 100644 --- a/ui/app/styles/components/stat-text.scss +++ b/ui/app/styles/components/stat-text.scss @@ -1,5 +1,8 @@ .stat-text-container { line-height: normal; + height: 100%; + display: flex; + flex-direction: column; &.l, &.m { @@ -13,6 +16,7 @@ font-weight: $font-weight-normal; color: $ui-gray-700; line-height: inherit; + flex-grow: 1; } .stat-value { font-size: $size-3; diff --git a/ui/app/templates/components/pricing-metrics-config.hbs b/ui/app/templates/components/clients/config.hbs similarity index 98% rename from ui/app/templates/components/pricing-metrics-config.hbs rename to ui/app/templates/components/clients/config.hbs index b6813735770cf..0551956de61af 100644 --- a/ui/app/templates/components/pricing-metrics-config.hbs +++ b/ui/app/templates/components/clients/config.hbs @@ -54,7 +54,8 @@ Save Cancel diff --git a/ui/app/templates/components/clients/history.hbs b/ui/app/templates/components/clients/history.hbs new file mode 100644 index 0000000000000..209b29f90fbe1 --- /dev/null +++ b/ui/app/templates/components/clients/history.hbs @@ -0,0 +1,94 @@ +{{#if (eq @model.config.queriesAvailable false)}} + {{#if (eq @model.config.enabled "On")}} + + {{else}} + + {{#if @model.config.configPath.canUpdate}} +

Go to configuration

+ {{/if}} + + {{/if}} +{{else}} +
+ {{#if (eq @tab "current")}} +

Current month

+

The below data is for the current month starting from the first day. For historical data, see the monthly history tab.

+ {{#if (eq @model.config.enabled 'Off')}} + + {{#if @model.config.configPath.canUpdate}} + Go to configuration + {{/if}} + + {{/if}} + {{else}} + {{#if (eq @model.config.enabled 'Off')}} + + Tracking is currently disabled and data is not being collected. Historical data can be searched, but you will need to edit the configuration to enable tracking again. + + {{/if}} +

Monthly history

+

This data is presented by full month. If there is data missing, it's possible that tracking was turned off at the time. Vault will only show data for contiguous blocks of time during which tracking was on.

+ + {{/if}} + {{#unless @model.activity.total}} + {{#if (eq @tab "current")}} + {{#if (eq @model.config.enabled 'On')}} + + {{/if}} + {{else}} + + {{/if}} + {{else}} +
+
+
+
+

Total usage

+

These totals are within this namespace and all its children.

+
+ + Learn more + +
+
+
+
+ +
+
+ +
+
+ +
+
+
+
+
+
+ + +
+
+ +
+
+ {{/unless}} +
+{{/if}} diff --git a/ui/app/templates/components/cluster-info.hbs b/ui/app/templates/components/cluster-info.hbs index c2a28a49cbd49..c404841d7f39c 100644 --- a/ui/app/templates/components/cluster-info.hbs +++ b/ui/app/templates/components/cluster-info.hbs @@ -116,12 +116,12 @@ {{/if}} {{/if}} - {{#if ( and (has-permission 'metrics' routeParams='activity') (not @cluster.dr.isSecondary) this.auth.currentToken)}} + {{#if ( and (has-permission 'clients' routeParams='activity') (not @cluster.dr.isSecondary) this.auth.currentToken)}}
  • - +
    - Metrics + Client count
    diff --git a/ui/app/templates/components/pricing-metrics-dates.hbs b/ui/app/templates/components/pricing-metrics-dates.hbs index 8376227edc1c7..9b565d5fee70a 100644 --- a/ui/app/templates/components/pricing-metrics-dates.hbs +++ b/ui/app/templates/components/pricing-metrics-dates.hbs @@ -41,14 +41,4 @@ {{date-format resultStart "MMM dd, yyyy"}} through {{date-format resultEnd "MMM dd, yyyy"}} {{/if}} - {{#if showResultsWarning}} -
    - -

    This data may not reflect your search exactly. This is because Vault will only show data for contiguous blocks of time during which tracking was on. - - Learn more here - -

    -
    - {{/if}} diff --git a/ui/app/templates/vault/cluster/metrics/edit.hbs b/ui/app/templates/vault/cluster/clients/edit.hbs similarity index 71% rename from ui/app/templates/vault/cluster/metrics/edit.hbs rename to ui/app/templates/vault/cluster/clients/edit.hbs index a2813333a1f9d..f2f04abbf4aaa 100644 --- a/ui/app/templates/vault/cluster/metrics/edit.hbs +++ b/ui/app/templates/vault/cluster/clients/edit.hbs @@ -6,4 +6,4 @@ - + diff --git a/ui/app/templates/vault/cluster/clients/index.hbs b/ui/app/templates/vault/cluster/clients/index.hbs new file mode 100644 index 0000000000000..ce71fefd74b7f --- /dev/null +++ b/ui/app/templates/vault/cluster/clients/index.hbs @@ -0,0 +1,47 @@ + + +

    + Vault Client Count +

    +     +     + +
    + +
    + + +{{#if (eq tab "config")}} + + + {{#if model.config.configPath.canUpdate}} + + Edit configuration + + {{/if}} + + + +{{else}} + +{{/if}} diff --git a/ui/app/templates/vault/cluster/metrics/config.hbs b/ui/app/templates/vault/cluster/metrics/config.hbs deleted file mode 100644 index 7878e676f89ad..0000000000000 --- a/ui/app/templates/vault/cluster/metrics/config.hbs +++ /dev/null @@ -1,36 +0,0 @@ - - -

    - Metrics -

    -     -     - -
    - -
    - - - - {{#if model.configPath.canUpdate}} - - Edit configuration - - {{/if}} - - - - diff --git a/ui/app/templates/vault/cluster/metrics/index.hbs b/ui/app/templates/vault/cluster/metrics/index.hbs deleted file mode 100644 index 2c5280829c096..0000000000000 --- a/ui/app/templates/vault/cluster/metrics/index.hbs +++ /dev/null @@ -1,78 +0,0 @@ - - -

    - Metrics -

    -     -     - -
    - -
    - -{{#if (eq model.config.queriesAvailable false)}} - {{#if (eq model.config.enabled "On")}} - - {{else}} - -

    Go to configuration

    -     - {{/if}} -{{else}} -
    - {{#if (eq model.config.enabled 'Off')}} - - This feature is currently disabled and data is not being collected. Edit the configuration to enable tracking again. - - {{/if}} -

    The active clients metric contributes to billing. It is collected at the end of each month alongside unique entities and direct active tokens. The data below includes the current namespace and all its children.

    - - {{#unless model.activity.total}} - - {{else}} -
    - - - -
    - {{/unless}} -
    -{{/if}} diff --git a/ui/lib/core/addon/components/bar-chart.js b/ui/lib/core/addon/components/bar-chart.js index 3e58d3e26c3c8..d4da82844f5d0 100644 --- a/ui/lib/core/addon/components/bar-chart.js +++ b/ui/lib/core/addon/components/bar-chart.js @@ -94,7 +94,7 @@ class BarChartComponent extends Component { container .append('div') .attr('class', 'chart-tooltip') - .attr('style', 'position: fixed; opacity: 0;') + .attr('style', 'position: absolute; opacity: 0;') .style('color', 'white') .style('background', `${TOOLTIP_BACKGROUND}`) .style('font-size', '.929rem') @@ -214,11 +214,11 @@ class BarChartComponent extends Component { select('.chart-tooltip') .style('opacity', 1) .style('max-width', '200px') - .style('left', `${event.pageX - 90}px`) - .style('top', `${event.pageY - 90}px`) + .style('left', `${event.pageX - 95}px`) + .style('top', `${event.pageY - 155}px`) .text( `${Math.round((chartData.total * 100) / totalCount)}% of total client counts: - ${chartData.distinct_entities} unique entities, ${chartData.non_entity_tokens} active tokens. + ${chartData.non_entity_tokens} active tokens, ${chartData.distinct_entities} unique entities. ` ); }); diff --git a/ui/mirage/config.js b/ui/mirage/config.js index ed33615b537ab..81cb56c563eb2 100644 --- a/ui/mirage/config.js +++ b/ui/mirage/config.js @@ -5,7 +5,7 @@ export default function() { this.get('sys/internal/counters/activity', function(db) { let data = {}; - const firstRecord = db['metrics/activities'].first(); + const firstRecord = db['clients/activities'].first(); if (firstRecord) { data = firstRecord; } @@ -18,7 +18,7 @@ export default function() { this.get('sys/internal/counters/config', function(db) { return { request_id: '00001', - data: db['metrics/configs'].first(), + data: db['clients/configs'].first(), }; }); diff --git a/ui/mirage/scenarios/default.js b/ui/mirage/scenarios/default.js index 5e65448276cf4..995311c4fe244 100644 --- a/ui/mirage/scenarios/default.js +++ b/ui/mirage/scenarios/default.js @@ -1,4 +1,4 @@ export default function(server) { - server.create('metrics/config'); + server.create('clients/config'); server.create('feature', { feature_flags: ['SOME_FLAG', 'VAULT_CLOUD_ADMIN_NAMESPACE'] }); } diff --git a/ui/tests/acceptance/usage-metrics-test.js b/ui/tests/acceptance/usage-metrics-test.js deleted file mode 100644 index d4d8a405fb35f..0000000000000 --- a/ui/tests/acceptance/usage-metrics-test.js +++ /dev/null @@ -1,106 +0,0 @@ -import { module, test } from 'qunit'; -import { visit, currentURL, findAll } from '@ember/test-helpers'; -import { setupApplicationTest } from 'ember-qunit'; -import setupMirage from 'ember-cli-mirage/test-support/setup-mirage'; -import { create } from 'ember-cli-page-object'; - -import authPage from 'vault/tests/pages/auth'; -import logout from 'vault/tests/pages/logout'; -import consoleClass from 'vault/tests/pages/components/console/ui-panel'; - -const consoleComponent = create(consoleClass); - -const tokenWithPolicy = async function(name, policy) { - await consoleComponent.runCommands([ - `write sys/policies/acl/${name} policy=${btoa(policy)}`, - `write -field=client_token auth/token/create policies=${name}`, - ]); - - return consoleComponent.lastLogOutput; -}; - -module('Acceptance | usage metrics', function(hooks) { - setupApplicationTest(hooks); - setupMirage(hooks); - - hooks.beforeEach(function() { - return authPage.login(); - }); - - hooks.afterEach(function() { - return logout.visit(); - }); - - test('it shows empty state when disabled and no data available', async function(assert) { - server.create('metrics/config', { enabled: 'disable' }); - await visit('/vault/metrics'); - - assert.equal(currentURL(), '/vault/metrics'); - assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); - assert.dom('[data-test-empty-state-title]').hasText('No data is being received'); - }); - - test('it shows empty state when enabled and no data available', async function(assert) { - server.create('metrics/config', { enabled: 'enable' }); - await visit('/vault/metrics'); - - assert.equal(currentURL(), '/vault/metrics'); - assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); - assert.dom('[data-test-empty-state-title]').hasText('No data is being received'); - }); - - test('it shows empty state when data available but not returned', async function(assert) { - server.create('metrics/config', { queries_available: true }); - await visit('/vault/metrics'); - - assert.equal(currentURL(), '/vault/metrics'); - assert.dom('[data-test-pricing-metrics-form]').exists('Pricing metrics date form exists'); - assert.dom('[data-test-pricing-result-dates]').doesNotExist('Pricing metric result dates are not shown'); - assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); - assert.dom('[data-test-empty-state-title]').hasText('No data found'); - }); - - test('it shows warning when disabled and data available', async function(assert) { - server.create('metrics/config', { queries_available: true, enabled: 'disable' }); - server.create('metrics/activity'); - await visit('/vault/metrics'); - - assert.equal(currentURL(), '/vault/metrics'); - assert.dom('[data-test-pricing-metrics-form]').exists('Pricing metrics date form exists'); - assert.dom('[data-test-tracking-disabled]').exists('Flash message exists'); - assert.dom('[data-test-tracking-disabled] .message-title').hasText('Tracking is disabled'); - }); - - test('it shows data when available from query', async function(assert) { - server.create('metrics/config', { queries_available: true }); - server.create('metrics/activity'); - await visit('/vault/metrics'); - - assert.equal(currentURL(), '/vault/metrics'); - assert.dom('[data-test-pricing-metrics-form]').exists('Pricing metrics date form exists'); - assert.dom('[data-test-configuration-tab]').exists('Metrics config tab exists'); - assert.dom('[data-test-tracking-disabled]').doesNotExist('Flash message does not exists'); - assert.ok(findAll('.selectable-card').length === 3, 'renders the counts'); - }); - - test('it shows metrics even if config endpoint not allowed', async function(assert) { - server.create('metrics/activity'); - const deny_config_policy = ` - path "sys/internal/counters/config" { - capabilities = ["deny"] - }, - `; - - const userToken = await tokenWithPolicy('no-metrics-config', deny_config_policy); - await logout.visit(); - await authPage.login(userToken); - - await visit('/vault/metrics'); - - assert.equal(currentURL(), '/vault/metrics'); - assert.dom('[data-test-pricing-metrics-form]').exists('Pricing metrics date form exists'); - assert.dom('[data-test-configuration-tab]').doesNotExist('Metrics config tab does not exist'); - assert.dom('[data-test-tracking-disabled]').doesNotExist('Flash message does not exists'); - assert.ok(findAll('.selectable-card').length === 3, 'renders the counts'); - }); -}); diff --git a/ui/tests/integration/components/pricing-metrics-config-test.js b/ui/tests/integration/components/clients-config-test.js similarity index 91% rename from ui/tests/integration/components/pricing-metrics-config-test.js rename to ui/tests/integration/components/clients-config-test.js index 592b9fbd64a3e..cc29955b76c73 100644 --- a/ui/tests/integration/components/pricing-metrics-config-test.js +++ b/ui/tests/integration/components/clients-config-test.js @@ -15,7 +15,7 @@ const routerService = Service.extend({ }, }); -module('Integration | Component | pricing-metrics-config', function(hooks) { +module('Integration | Component | client count config', function(hooks) { setupRenderingTest(hooks); const createAttr = (name, type, options) => { @@ -50,7 +50,7 @@ module('Integration | Component | pricing-metrics-config', function(hooks) { }); test('it shows the table with the correct rows by default', async function(assert) { - await render(hbs``); + await render(hbs``); assert.dom('[data-test-pricing-metrics-config-table]').exists('Pricing metrics config table exists'); const rows = document.querySelectorAll('.info-table-row'); @@ -72,7 +72,7 @@ module('Integration | Component | pricing-metrics-config', function(hooks) { test('TODO: it shows the config edit form when mode = edit', async function(assert) { await render(hbs` - + `); assert.dom('[data-test-pricing-metrics-config-form]').exists('Pricing metrics config form exists'); @@ -89,7 +89,7 @@ module('Integration | Component | pricing-metrics-config', function(hooks) { this.set('model', simModel); await render(hbs` - + `); await click('[data-test-edit-metrics-config-save]'); @@ -110,7 +110,7 @@ module('Integration | Component | pricing-metrics-config', function(hooks) { this.set('model', simModel); await render(hbs` - + `); await click('[data-test-edit-metrics-config-save]'); @@ -131,7 +131,7 @@ module('Integration | Component | pricing-metrics-config', function(hooks) { this.set('model', simModel); await render(hbs` - + `); await click('[data-test-edit-metrics-config-save]'); diff --git a/ui/tests/integration/components/clients-current-test.js b/ui/tests/integration/components/clients-current-test.js new file mode 100644 index 0000000000000..9d78568f6b0d0 --- /dev/null +++ b/ui/tests/integration/components/clients-current-test.js @@ -0,0 +1,57 @@ +import { module, test } from 'qunit'; +import EmberObject from '@ember/object'; +import { render } from '@ember/test-helpers'; +import { setupRenderingTest } from 'ember-qunit'; +import hbs from 'htmlbars-inline-precompile'; + +module('Integration | Component | client count current', function(hooks) { + setupRenderingTest(hooks); + hooks.beforeEach(function() { + let model = EmberObject.create({ + config: {}, + activity: {}, + }); + this.model = model; + this.tab = 'current'; + }); + + test('it shows empty state when disabled and no data available', async function(assert) { + Object.assign(this.model.config, { enabled: 'Off', queriesAvailable: false }); + await render(hbs``); + + assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); + assert.dom('[data-test-empty-state-title]').hasText('Data tracking is disabled'); + }); + + test('it shows empty state when enabled and no data available', async function(assert) { + Object.assign(this.model.config, { enabled: 'On', queriesAvailable: false }); + await render(hbs``); + + assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); + assert.dom('[data-test-empty-state-title]').hasText('No monthly history'); + }); + + test('it shows empty state when data available but not returned', async function(assert) { + Object.assign(this.model.config, { queriesAvailable: true, enabled: 'On' }); + await render(hbs``); + assert.dom('[data-test-pricing-metrics-form]').doesNotExist('Date range component should not exists'); + assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); + assert.dom('[data-test-empty-state-title]').hasText('No data received'); + }); + + test('it shows data when available from query', async function(assert) { + Object.assign(this.model.config, { queriesAvailable: true, configPath: { canRead: true } }); + Object.assign(this.model.activity, { + total: { + clients: 1234, + distinct_entities: 234, + non_entity_tokens: 232, + }, + }); + + await render(hbs``); + assert.dom('[data-test-pricing-metrics-form]').doesNotExist('Date range component should not exists'); + assert.dom('[data-test-tracking-disabled]').doesNotExist('Flash message does not exists'); + assert.dom('[data-test-client-count-stats]').exists('Client count data exists'); + }); +}); diff --git a/ui/tests/integration/components/clients-history-test.js b/ui/tests/integration/components/clients-history-test.js new file mode 100644 index 0000000000000..dc4b8ce4dd163 --- /dev/null +++ b/ui/tests/integration/components/clients-history-test.js @@ -0,0 +1,67 @@ +import { module, test } from 'qunit'; +import EmberObject from '@ember/object'; +import { render } from '@ember/test-helpers'; +import { setupRenderingTest } from 'ember-qunit'; +import hbs from 'htmlbars-inline-precompile'; + +module('Integration | Component | client count history', function(hooks) { + setupRenderingTest(hooks); + hooks.beforeEach(function() { + let model = EmberObject.create({ + config: {}, + activity: {}, + }); + this.model = model; + this.tab = 'history'; + }); + + test('it shows empty state when disabled and no data available', async function(assert) { + Object.assign(this.model.config, { enabled: 'Off', queriesAvailable: false }); + await render(hbs``); + + assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); + assert.dom('[data-test-empty-state-title]').hasText('Data tracking is disabled'); + }); + + test('it shows empty state when enabled and no data available', async function(assert) { + Object.assign(this.model.config, { enabled: 'On', queriesAvailable: false }); + await render(hbs``); + + assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); + assert.dom('[data-test-empty-state-title]').hasText('No monthly history'); + }); + + test('it shows empty state when data available but not returned', async function(assert) { + Object.assign(this.model.config, { queriesAvailable: true }); + await render(hbs``); + assert.dom('[data-test-pricing-metrics-form]').exists('Date range form component exists'); + assert.dom('[data-test-pricing-result-dates]').doesNotExist('Date range form result dates are not shown'); + assert.dom('[data-test-component="empty-state"]').exists('Empty state exists'); + assert.dom('[data-test-empty-state-title]').hasText('No data received'); + }); + + test('it shows warning when disabled and data available', async function(assert) { + Object.assign(this.model.config, { queriesAvailable: true, enabled: 'Off' }); + await render(hbs``); + + assert.dom('[data-test-pricing-metrics-form]').exists('Date range form component exists'); + assert.dom('[data-test-tracking-disabled]').exists('Flash message exists'); + assert.dom('[data-test-tracking-disabled] .message-title').hasText('Tracking is disabled'); + }); + + test('it shows data when available from query', async function(assert) { + Object.assign(this.model.config, { queriesAvailable: true, configPath: { canRead: true } }); + Object.assign(this.model.activity, { + total: { + clients: 1234, + distinct_entities: 234, + non_entity_tokens: 232, + }, + }); + + await render(hbs``); + assert.dom('[data-test-pricing-metrics-form]').exists('Date range form component exists'); + assert.dom('[data-test-tracking-disabled]').doesNotExist('Flash message does not exists'); + assert.dom('[data-test-client-count-stats]').exists('Client count data exists'); + }); +}); diff --git a/ui/tests/integration/components/pricing-metrics-dates-test.js b/ui/tests/integration/components/pricing-metrics-dates-test.js index 3b8af51f80bd6..949a995819616 100644 --- a/ui/tests/integration/components/pricing-metrics-dates-test.js +++ b/ui/tests/integration/components/pricing-metrics-dates-test.js @@ -55,34 +55,6 @@ module('Integration | Component | pricing-metrics-dates', function(hooks) { assert.dom('[data-test-results-date-warning]').doesNotExist('Does not show result states warning'); }); - test('If result and query start dates are > 1 day apart, warning is shown', async function(assert) { - this.set('resultStart', new Date(2020, 1, 20)); - this.set('resultEnd', new Date(2020, 9, 31)); - await render(hbs` - - `); - assert.dom('[data-test-results-date-warning]').exists('shows states warning'); - }); - - test('If result and query end dates are > 1 day apart, warning is shown', async function(assert) { - this.set('resultStart', new Date(2020, 1, 1)); - this.set('resultEnd', new Date(2020, 9, 15)); - await render(hbs` - - `); - assert.dom('[data-test-results-date-warning]').exists('shows states warning'); - }); - test('it shows appropriate errors on input form', async function(assert) { const lastAvailable = endOfMonth(subMonths(startOfToday(), 1)); const firstAvailable = subMonths(lastAvailable, 12); From 75b0357c204ebf43f0d833cda488239c24d618ae Mon Sep 17 00:00:00 2001 From: Arnav Palnitkar Date: Wed, 15 Sep 2021 00:31:44 -0700 Subject: [PATCH 2/5] Fixed navbar permission - Added changelog --- changelog/12554.txt | 3 +++ ui/app/templates/vault/cluster.hbs | 11 ++++++----- 2 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 changelog/12554.txt diff --git a/changelog/12554.txt b/changelog/12554.txt new file mode 100644 index 0000000000000..e3549ecdf6c38 --- /dev/null +++ b/changelog/12554.txt @@ -0,0 +1,3 @@ +```release-note:feature +ui: client count monthly view +``` \ No newline at end of file diff --git a/ui/app/templates/vault/cluster.hbs b/ui/app/templates/vault/cluster.hbs index 4cbd1f616af37..ab20e6f0a4d02 100644 --- a/ui/app/templates/vault/cluster.hbs +++ b/ui/app/templates/vault/cluster.hbs @@ -72,15 +72,16 @@
    - {{else if (and (has-permission 'metrics' routeParams='activity') (not cluster.dr.isSecondary) auth.currentToken)}} + {{else if (and (has-permission 'clients' routeParams='activity') (not cluster.dr.isSecondary) auth.currentToken)}}
    -
    +
    {{#link-to - "vault.cluster.metrics" - current-when="vault.cluster.metrics" + "vault.cluster.clients" + (query-params tab="history") + current-when="vault.cluster.clients" data-test-navbar-item='metrics' }} - Metrics + Client count {{/link-to}}
    From de68f06f67b2ebb3648f086dad12cac6322ef536 Mon Sep 17 00:00:00 2001 From: Arnav Palnitkar Date: Wed, 15 Sep 2021 11:37:17 -0700 Subject: [PATCH 3/5] Updated the model for current month data --- ui/app/components/clients/history.js | 16 +++++++++- ui/app/models/clients/activity.js | 3 ++ .../templates/components/clients/history.hbs | 30 ++++++++++--------- 3 files changed, 34 insertions(+), 15 deletions(-) diff --git a/ui/app/components/clients/history.js b/ui/app/components/clients/history.js index 6a71ed6da5e9e..ca2f640f8e5f8 100644 --- a/ui/app/components/clients/history.js +++ b/ui/app/components/clients/history.js @@ -3,7 +3,14 @@ import Component from '@glimmer/component'; export default class HistoryComponent extends Component { max_namespaces = 10; - get dataset() { + get hasClientData() { + if (this.args.tab === 'current') { + return this.args.model.activity && this.args.model.activity.clients; + } + return this.args.model.activity && this.args.model.activity.total; + } + + get barChartDataset() { if (!this.args.model.activity || !this.args.model.activity.byNamespace) { return null; } @@ -23,4 +30,11 @@ export default class HistoryComponent extends Component { }; }); } + + get showGraphs() { + if (!this.args.model.activity || !this.args.model.activity.byNamespace) { + return null; + } + return this.args.model.activity.byNamespace.length > 1; + } } diff --git a/ui/app/models/clients/activity.js b/ui/app/models/clients/activity.js index ba88d9839d91a..4cbd4fb114528 100644 --- a/ui/app/models/clients/activity.js +++ b/ui/app/models/clients/activity.js @@ -5,4 +5,7 @@ export default Model.extend({ byNamespace: attr('array'), endTime: attr('string'), startTime: attr('string'), + clients: attr('number'), + distinct_entities: attr('number'), + non_entity_tokens: attr('number'), }); diff --git a/ui/app/templates/components/clients/history.hbs b/ui/app/templates/components/clients/history.hbs index 209b29f90fbe1..9eff3cc6e72c5 100644 --- a/ui/app/templates/components/clients/history.hbs +++ b/ui/app/templates/components/clients/history.hbs @@ -41,10 +41,10 @@ @retentionMonths={{@model.config.retentionMonths}} /> {{/if}} - {{#unless @model.activity.total}} + {{#unless this.hasClientData}} {{#if (eq @tab "current")}} {{#if (eq @model.config.enabled 'On')}} - + {{/if}} {{else}} @@ -64,31 +64,33 @@
    -
    -
    -
    -
    -
    - - -
    -
    + {{#if this.showGraphs}} +
    +
    + + +
    +
    +
    -
    + {{/if}} {{/unless}}
    {{/if}} From 3742c8f13c586b8dd4bb0ae765dee192e5242e44 Mon Sep 17 00:00:00 2001 From: Arnav Palnitkar Date: Wed, 15 Sep 2021 14:24:38 -0700 Subject: [PATCH 4/5] Fixed current month tests --- ui/tests/integration/components/clients-current-test.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ui/tests/integration/components/clients-current-test.js b/ui/tests/integration/components/clients-current-test.js index 9d78568f6b0d0..ace20b3897457 100644 --- a/ui/tests/integration/components/clients-current-test.js +++ b/ui/tests/integration/components/clients-current-test.js @@ -42,11 +42,9 @@ module('Integration | Component | client count current', function(hooks) { test('it shows data when available from query', async function(assert) { Object.assign(this.model.config, { queriesAvailable: true, configPath: { canRead: true } }); Object.assign(this.model.activity, { - total: { - clients: 1234, - distinct_entities: 234, - non_entity_tokens: 232, - }, + clients: 1234, + distinct_entities: 234, + non_entity_tokens: 232, }); await render(hbs``); From 45fa96b0b6e44c0bd3ee5e0522c920f39700e7e4 Mon Sep 17 00:00:00 2001 From: Arnav Palnitkar Date: Thu, 16 Sep 2021 13:54:26 -0700 Subject: [PATCH 5/5] Fixed indentation and chart label --- ui/app/components/clients/history.js | 2 +- .../templates/components/clients/history.hbs | 209 +++++++++++------- .../templates/vault/cluster/clients/index.hbs | 1 - 3 files changed, 132 insertions(+), 80 deletions(-) diff --git a/ui/app/components/clients/history.js b/ui/app/components/clients/history.js index ca2f640f8e5f8..cb4ba01fb32f9 100644 --- a/ui/app/components/clients/history.js +++ b/ui/app/components/clients/history.js @@ -17,7 +17,7 @@ export default class HistoryComponent extends Component { let dataset = this.args.model.activity.byNamespace; // Filter out root data dataset = dataset.filter(item => { - return item.namespace_id != 'root'; + return item.namespace_id !== 'root'; }); // Show only top 10 namespaces dataset = dataset.slice(0, this.max_namespaces); diff --git a/ui/app/templates/components/clients/history.hbs b/ui/app/templates/components/clients/history.hbs index 9eff3cc6e72c5..6936c11cd8b92 100644 --- a/ui/app/templates/components/clients/history.hbs +++ b/ui/app/templates/components/clients/history.hbs @@ -1,96 +1,149 @@ {{#if (eq @model.config.queriesAvailable false)}} - {{#if (eq @model.config.enabled "On")}} - - {{else}} - - {{#if @model.config.configPath.canUpdate}} -

    Go to configuration

    - {{/if}} -     - {{/if}} + {{#if (eq @model.config.enabled 'On')}} + + {{else}} + + {{#if @model.config.configPath.canUpdate}} +

    + + Go to configuration + +

    + {{/if}} +     + {{/if}} {{else}} -
    - {{#if (eq @tab "current")}} -

    Current month

    -

    The below data is for the current month starting from the first day. For historical data, see the monthly history tab.

    - {{#if (eq @model.config.enabled 'Off')}} - - {{#if @model.config.configPath.canUpdate}} - Go to configuration - {{/if}} - - {{/if}} +
    + {{#if (eq @tab 'current')}} +

    + Current month +

    +

    + The below data is for the current month starting from the first day. For historical data, see the monthly + history tab. +

    + {{#if (eq @model.config.enabled 'Off')}} + + {{#if @model.config.configPath.canUpdate}} + + Go to configuration + + {{/if}} + + {{/if}} {{else}} - {{#if (eq @model.config.enabled 'Off')}} - - Tracking is currently disabled and data is not being collected. Historical data can be searched, but you will need to edit the configuration to enable tracking again. - - {{/if}} -

    Monthly history

    -

    This data is presented by full month. If there is data missing, it's possible that tracking was turned off at the time. Vault will only show data for contiguous blocks of time during which tracking was on.

    - + Tracking is currently disabled and data is not being collected. Historical data can be searched, but you will + need to + + edit the configuration + + to enable tracking again. + + {{/if}} +

    + Monthly history +

    +

    + This data is presented by full month. If there is data missing, it's possible that tracking was turned off at + the time. Vault will only show data for contiguous blocks of time during which tracking was on. +

    + + /> {{/if}} {{#unless this.hasClientData}} - {{#if (eq @tab "current")}} - {{#if (eq @model.config.enabled 'On')}} - - {{/if}} - {{else}} - + {{#if (eq @tab 'current')}} + {{#if (eq @model.config.enabled 'On')}} + {{/if}} + {{else}} + + {{/if}} {{else}} -
    -
    -
    -
    -

    Total usage

    -

    These totals are within this namespace and all its children.

    -
    - - Learn more - +
    +
    +
    +
    +

    + Total usage +

    +

    + These totals are within this namespace and all its children. +

    -
    -
    -
    - -
    -
    - -
    -
    - -
    + + Learn more + +
    +
    +
    +
    +
    +
    +
    -
    - {{#if this.showGraphs}} -
    -
    - - -
    -
    - -
    +
    +
    - {{/if}} +
    +
    +
    + {{#if this.showGraphs}} +
    +
    + +
    +
    +
    + {{/if}} {{/unless}} -
    -{{/if}} +
    +{{/if}} \ No newline at end of file diff --git a/ui/app/templates/vault/cluster/clients/index.hbs b/ui/app/templates/vault/cluster/clients/index.hbs index ce71fefd74b7f..50e68a64a15e7 100644 --- a/ui/app/templates/vault/cluster/clients/index.hbs +++ b/ui/app/templates/vault/cluster/clients/index.hbs @@ -30,7 +30,6 @@
    - {{#if (eq tab "config")}}