From 927dc3a159278206b3a74a02f2f190c7bb6ee255 Mon Sep 17 00:00:00 2001 From: Jordan Reimer Date: Fri, 22 Oct 2021 11:53:48 -0600 Subject: [PATCH 1/4] updates info table row value font --- ui/lib/core/addon/templates/components/info-table-row.hbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/lib/core/addon/templates/components/info-table-row.hbs b/ui/lib/core/addon/templates/components/info-table-row.hbs index 676bea71f42e4..24fed394d0a78 100644 --- a/ui/lib/core/addon/templates/components/info-table-row.hbs +++ b/ui/lib/core/addon/templates/components/info-table-row.hbs @@ -55,7 +55,7 @@ @horizontalPosition="left" as |T|> - {{value}} + {{value}} {{else}} - {{value}} + {{value}} {{/if}} {{/if}} {{/if}} From 3bd98d7a9fce61a4de32c3c7e94fee633e7f9673 Mon Sep 17 00:00:00 2001 From: Jordan Reimer Date: Fri, 22 Oct 2021 13:13:01 -0600 Subject: [PATCH 2/4] adds changelog --- changelog/12908.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelog/12908.txt diff --git a/changelog/12908.txt b/changelog/12908.txt new file mode 100644 index 0000000000000..2e542174f74bf --- /dev/null +++ b/changelog/12908.txt @@ -0,0 +1,3 @@ +```release-note:improvement +ui: Updates font for table row value fields +``` \ No newline at end of file From b13b90d0134ea3a6273c8ff8c6abc35927ac04ff Mon Sep 17 00:00:00 2001 From: Jordan Reimer Date: Fri, 22 Oct 2021 13:46:59 -0600 Subject: [PATCH 3/4] updates tests --- ui/tests/integration/components/info-table-row-test.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/tests/integration/components/info-table-row-test.js b/ui/tests/integration/components/info-table-row-test.js index b24f48f5adaa3..d597617208b2f 100644 --- a/ui/tests/integration/components/info-table-row-test.js +++ b/ui/tests/integration/components/info-table-row-test.js @@ -47,8 +47,7 @@ module('Integration | Component | InfoTableRow', function(hooks) { />`); assert.dom('[data-test-component="info-table-row"]').exists(); - let string = document.querySelector('code').textContent; - assert.equal(string, VALUE, 'renders value as passed through'); + assert.dom('[data-test-row-value]').hasText(VALUE, 'renders value as passed through'); this.set('value', ''); assert @@ -101,8 +100,7 @@ module('Integration | Component | InfoTableRow', function(hooks) { @label={{label}} @isLink={{true}} />`); - let string = document.querySelector('code').textContent; - assert.equal(string, VALUE, 'renders value in code element and not in a tag'); + assert.dom('[data-test-row-value]').hasText(VALUE, 'renders value in code element and not in a tag'); }); test('it renders links if isLink is true and type is array', async function(assert) { From dbe6cfdb75353ac0d271e6ce8dcafab2c61a2d0a Mon Sep 17 00:00:00 2001 From: Jordan Reimer Date: Fri, 22 Oct 2021 14:35:45 -0600 Subject: [PATCH 4/4] attempts to fix flaky mount-secret-backend acceptance test --- ui/tests/acceptance/settings/mount-secret-backend-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/tests/acceptance/settings/mount-secret-backend-test.js b/ui/tests/acceptance/settings/mount-secret-backend-test.js index 17c0eddea7ff1..aa99264097725 100644 --- a/ui/tests/acceptance/settings/mount-secret-backend-test.js +++ b/ui/tests/acceptance/settings/mount-secret-backend-test.js @@ -128,7 +128,7 @@ module('Acceptance | settings/mount-secret-backend', function(hooks) { `write sys/policies/acl/kv-v2-degrade policy=${btoa(V2_POLICY)}`, 'write -field=client_token auth/token/create policies=kv-v2-degrade', ]); - + await settled(); let userToken = consoleComponent.lastLogOutput; await logout.visit(); await authPage.login(userToken);