New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HZ-1411] User Defined Types information_schema tables #23267

Merged

ivanthescientist merged 2 commits into hazelcast:master from ivanthescientist:feature/5.3/udt_info_schema_table

Jan 10, 2023

Contributor

ivanthescientist commented Dec 27, 2022

Adds attributes and user_defined_types tables to information_schema.

Closes #22062.


          initial version

7106be0

ivanthescientist added Type: Enhancement Source: Internal Module: Jet labels

ivanthescientist added this to the 5.3.0 milestone

ivanthescientist requested review from viliam-durina, burakgok, Fly-Style and k-jamroz

December 27, 2022 12:38

ivanthescientist commented

View reviewed changes

...st-sql/src/main/java/com/hazelcast/jet/sql/impl/connector/infoschema/UDTAttributesTable.java

+                          case TIMESTAMP:
+                          case TIMESTAMP_WITH_TIME_ZONE:
+                              // number of digits after the dot when specifying seconds - 9 for nanoseconds
+                              return 9;

Contributor Author

ivanthescientist Dec 27, 2022

This bit was confusing - the value here is number of digits (according to Postgres docs) after the dot, Postgres provides 6 here for both TIMESTAMP and TIMESTAMP WITH TIME ZONE here, which means microseconds, but I think we return OffsetDateTime which allows querying for Nanoseconds? Not sure what's best.

viliam-durina approved these changes

View reviewed changes

k-jamroz approved these changes

View reviewed changes


          Add comment

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

hazelcast deleted a comment from hz-devops-test

ivanthescientist merged commit 87a282c into hazelcast:master

ivanthescientist deleted the feature/5.3/udt_info_schema_table branch

January 10, 2023 08:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment