Disallow different types of generic records in GenericRecordBuilder.setGenericRecord API-1773 #23522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
added
Type: Defect
Team: Client
Source: Internal
mdumandag
reviewed
Jan 31, 2023
...ain/java/com/hazelcast/internal/serialization/impl/compact/AbstractGenericRecordBuilder.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hazelcast/internal/serialization/impl/compact/AbstractGenericRecordBuilder.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hazelcast/internal/serialization/impl/compact/AbstractGenericRecordBuilder.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hazelcast/internal/serialization/impl/compact/AbstractGenericRecordBuilder.java
Show resolved
Hide resolved
mdumandag
approved these changes
Feb 1, 2023
ihsandemir
approved these changes
Feb 1, 2023
ihsandemir
added
the
All Languages Should Check
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, GenericRecordBuilder.setGenericRecord does not throw if the value is not of the same type of generic record. (compact for compact, portable for portable)
We instead throw a cast exception while trying to do toData. We should do it during the setter.
Breaking changes (list specific methods/types/messages):
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset@Nonnull/@Nullableannotations@sincetags in JavadocI don't think we need backports for this change.