No error on null key [HZ-2086] #23768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaszGaweda
added
Type: Enhancement
Source: Internal
|
run-cdc-debezium-tests |
ldziedziul
approved these changes
Feb 27, 2023
orcunc
reviewed
Mar 1, 2023
| .debezium("postgres", PostgresConnector.class) | ||
| .setProperty("database.server.name", "dbserver1") | ||
| .setProperty("database.hostname", container.getHost()) | ||
| .setProperty("database.port", Integer.toString(container.getMappedPort(POSTGRESQL_PORT))) |
There was a problem hiding this comment.
You can use container.getFirstMappedPort() instead of container.getMappedPort()
There was a problem hiding this comment.
I can, but I think it's more explicit this way - I guess it's personal preference
orcunc
reviewed
Mar 1, 2023
| try (Connection connection = getPostgreSqlConnection(container.getJdbcUrl(), container.getUsername(), | ||
| container.getPassword())) { | ||
| connection.setSchema("inventory"); | ||
| Statement statement = connection.createStatement(); |
There was a problem hiding this comment.
Statement should be closed.
try (Statement statement = connection.createStatement()) {...}
There was a problem hiding this comment.
Good catch! c63631c
orcunc
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debezium relaxed the requirement for keys - it can be null now. In such cases, do not throw an exception.
Fixes #23655
Breaking changes (list specific methods/types/messages):
ChangeRecord#key()is now@Nullable, was@NonnullChecklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset