Add support for changing JobConfig of a suspended job [HZ-1650] #23862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no getters - instead of copying javadoc reference to JobConfig - non-null values, the fact that we use nulls for non-set options is internal - don't make assumptions about long value in serialization
# Conflicts: # hazelcast/src/test/resources/2.6.protocol.compatibility.binary # hazelcast/src/test/resources/2.6.protocol.compatibility.null.binary
viliam-durina
added
Type: Enhancement
Team: SQL
Add to Release Notes
SQL-only
5 tasks
viliam-durina
removed
SQL-only
frant-hartm
approved these changes
Mar 7, 2023
|
we should add tests in EE that ensure that config can be changed in |
k-jamroz
requested changes
Mar 7, 2023
mdumandag
reviewed
Mar 7, 2023
...src/main/java/com/hazelcast/jet/impl/client/protocol/task/JetUpdateJobConfigMessageTask.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/hazelcast/jet/impl/client/protocol/task/JetUpdateJobConfigMessageTask.java
Show resolved
Hide resolved
The test relied that INSERT doesn't insert any rows, if it fails with `AccumulationLimitExceededException`. But it might have inserted some rows, and if it manages to insert them, the query will fail with "Duplicate key" after restart. The new test uses a window aggregation with three keys. This fails if max accumulated records is 2, before emitting anything from the aggregation, so the INSERT doesn't fail.
The test relied on window aggregation, but window aggregation didn't support the max accumulation limit. It actually failed due to the insert failing, which was non-deterministic for the same reason as the previous fix. This PR replaces INSERT with SINK, uses more keys (because they are spread across multiple processors), and also adds the accumulation check to the SlidingWindowP.
k-jamroz
approved these changes
Mar 8, 2023
mdumandag
approved these changes
Mar 8, 2023
5 tasks
# Conflicts: # hazelcast/src/main/java/com/hazelcast/jet/impl/ClientJobProxy.java # hazelcast/src/main/java/com/hazelcast/jet/impl/client/protocol/task/JetMessageTaskFactoryProvider.java # hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_6.java # hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_2_6.java # hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/MemberCompatibilityNullTest_2_6.java # hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/MemberCompatibilityTest_2_6.java # hazelcast/src/test/resources/2.6.protocol.compatibility.binary # hazelcast/src/test/resources/2.6.protocol.compatibility.null.binary
# Conflicts: # hazelcast/src/test/resources/2.6.protocol.compatibility.binary # hazelcast/src/test/resources/2.6.protocol.compatibility.null.binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #23523.
Adds support for changing
JobConfigof a suspended job.Protocol changes: hazelcast/hazelcast-client-protocol#450