Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Kubernetes Client only for API discovery mode #23883

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Create Kubernetes Client only for API discovery mode #23883

merged 1 commit into from
Mar 21, 2023

Conversation

ivyanni
Copy link
Contributor

@ivyanni ivyanni commented Mar 8, 2023 •
edited by hasancelik

Logic specific for Kubernetes API discovery mode including KubernetesClient build moved to KubernetesAPIEndpointResolver. It should resolve an issue with unexpected requests to Kube API when DNS discovery mode is chosen.

Fixes #23208

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Mar 8, 2023
@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Mar 8, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hasancelik
Copy link
Contributor

@ivyanni Thanks a lot for the PR. Sorry for the comment spamming 🙂 Currently, I am trying to find the reason behind it.

We will be looking over your PR soon.

@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@hazelcast hazelcast deleted a comment from devOpsHazelcast Mar 13, 2023
@degerhz degerhz added this to the 5.3 Backlog milestone Mar 14, 2023
SeriyBg
SeriyBg approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@SeriyBg SeriyBg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasancelik
Copy link
Contributor

run-lab-run

@hasancelik
Copy link
Contributor

Hi @ivyanni, could you backport your changes to 5.1.z and 5.2.z branches?

@hasancelik hasancelik merged commit 5bc62c8 into hazelcast:master Mar 21, 2023
@ivyanni
Copy link
Contributor Author

ivyanni commented Mar 21, 2023

Hi @ivyanni, could you backport your changes to 5.1.z and 5.2.z branches?

Yes, will do

This was referenced Mar 21, 2023
Merged
Merged
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

17 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@degerhz degerhz modified the milestones: 5.3 Backlog, 5.3.0 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeriyBg SeriyBg SeriyBg approved these changes

@dzeromski-hazelcast dzeromski-hazelcast dzeromski-hazelcast approved these changes

Assignees
No one assigned
Labels
Add to Release Notes Module: Discovery SPI Module: Kubernetes Source: Community PR or issue was opened by a community user Team: Cloud Native Type: Defect
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

Requests to Kubernetes API are sent although DNS Lookup mode is chosen
7 participants
@ivyanni @devOpsHazelcast @hasancelik @SeriyBg @dzeromski-hazelcast @degerhz @hz-devops-test