Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS 1.3 support in RestClient #24616

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix TLS 1.3 support in RestClient #24616

merged 1 commit into from
May 23, 2023

Conversation

kwart
Copy link
Member

@kwart kwart commented May 22, 2023 •
edited

When custom CA certificates was used, TLSv1.2 was enforced.
The REST calls failed in TLSv1.3-only Kubernetes environments.

This PR removes the explicit TLS version specification while creating the SSLContext.

@kwart kwart added this to the 5.4.0 milestone May 22, 2023
@kwart kwart requested review from SeriyBg and ramizdundar May 22, 2023 13:58
@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   ElasticSinkBuilderTest.when_writeToFailingSink_then_shouldCloseClient:69->HazelcastTestSupport.assertTrueEventually:1389->HazelcastTestSupport.assertTrueEventually:1285 
Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e>
[INFO] 
[ERROR] Tests run: 26, Failures: 1, Errors: 0, Skipped: 0
[INFO] 

[ERROR] There are test failures.

@kwart
Copy link
Member Author

kwart commented May 23, 2023

run-lam-run

@kwart kwart merged commit cb69235 into hazelcast:master May 23, 2023
8 checks passed
@kwart kwart deleted the fix/5.4/tls13-in-RestClient branch May 23, 2023 10:30
@kwart
Copy link
Member Author

kwart commented May 23, 2023

Thanks for the reviews, Ramiz & Sergii.

This was referenced May 23, 2023
Merged
Merged
Merged
Merged
kwart added a commit that referenced this pull request May 23, 2023
@kwart
Fix TLS 1.3 support in RestClient [5.1.z] (#24625)
eac74e0 
Backports #24616 to `5.1.z`
kwart added a commit that referenced this pull request May 23, 2023
@kwart
Fix TLS 1.3 support in RestClient [5.0.z] (#24626)
71d24b4 
Backports #24616 to `5.0.z`
kwart added a commit that referenced this pull request May 23, 2023
@kwart
Fix TLS 1.3 support in RestClient [5.2.z] (#24624)
a65b268 
Backports #24616 to `5.2.z`
kwart added a commit that referenced this pull request May 23, 2023
@kwart
Fix TLS 1.3 support in RestClient [5.3.z] (#24623)
0f7e452 
Backports #24616 to `5.3.z`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeriyBg SeriyBg SeriyBg approved these changes

@ramizdundar ramizdundar ramizdundar approved these changes

Assignees
No one assigned
Labels
Module: Kubernetes Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwart @hz-devops-test @SeriyBg @ramizdundar