Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent sending empty map interceptors information to new members #24639

Merged
merged 1 commit into from
May 26, 2023
Merged

Prevent sending empty map interceptors information to new members #24639

merged 1 commit into from
May 26, 2023

Conversation

azotcsit
Copy link
Contributor

@azotcsit azotcsit commented May 24, 2023 •
edited

Resolves #24635

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label May 24, 2023
@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented May 24, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@vbekiaris vbekiaris added this to the 5.4.0 milestone May 25, 2023
@vbekiaris
Copy link
Contributor

run-lab-run

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 



      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
      



  

  @vbekiaris





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
run-lab-run

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  
  

  
      @ahmetmircik
  ahmetmircik


          self-requested a review


    
      May 25, 2023 10:57
    
    









      

  
        

  

      

  ahmetmircik
  

  
          

            
                ahmetmircik
  

            

            approved these changes


            
                
                  May 26, 2023
                
            
          


          



              
    View reviewed changes
  


          





        

  
  
  
            

                    

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
  Member


      

  


  

    

      @ahmetmircik

      
          ahmetmircik
  

      

      

      left a comment




      
    


  



                

                    

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM

    

  
  




                    

                  
  

    
  
  

  

  




                    

                  
                








      

  
  
  




  








      

  
        





      

  
      



  

  @vbekiaris





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
thanks for the PR @azotcsit, merging now.

happy Hazelcasting!

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  

  


        
        @vbekiaris
  vbekiaris



        merged commit 02e4cbb
      into

      
  
    hazelcast:master
  


    May 26, 2023

      

        3 checks passed
      


      

        
          
  
  

        
      

  







  


  
    
  
  

    
  azotcsit 

      added a commit
        to azotcsit/hazelcast
      that referenced
      this pull request

    
      May 26, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (ha…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          b2487d2
        
      

    

  

    

      
…zelcast#24639)

Resolves hazelcast#24635

(cherry picked from commit 02e4cbb)

    




    

  




  


  
    
  
  

    
  azotcsit 

      added a commit
        to azotcsit/hazelcast
      that referenced
      this pull request

    
      May 26, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (ha…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          6584f63
        
      

    

  

    

      
…zelcast#24639)

Resolves hazelcast#24635

(cherry picked from commit 02e4cbb)

    




    

  




  


  
    
  
  

    
  azotcsit 

      added a commit
        to azotcsit/hazelcast
      that referenced
      this pull request

    
      May 26, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (ha…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          d13687e
        
      

    

  

    

      
…zelcast#24639)

Resolves hazelcast#24635

(cherry picked from commit 02e4cbb)

    




    

  




  


  
    
  
  

    
  azotcsit 

      added a commit
        to azotcsit/hazelcast
      that referenced
      this pull request

    
      May 26, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (ha…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          dd529c3
        
      

    

  

    

      
…zelcast#24639)

Resolves hazelcast#24635

(cherry picked from commit 02e4cbb)

    




    

  




  

  
  

  
      @azotcsit
  azotcsit


    
    deleted the
    
      
        map-interceptors-master
    
    branch

    
      May 26, 2023 14:31
    
    




  

  

    
  


  

      

  This was referenced May 26, 2023





  


  

      
   Merged

  






      






  


  

      
   Merged

  






      






  


  

      
   Merged

  






      






  


  

      
   Merged

  






  









      

  
      



  

  @azotcsit





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  Author


  


  

    

  





      


        


  
    

      
          
@vbekiaris @ahmetmircik

Thanks for the review! I backported the changes to other 5.x.z branches as per the discussion in Slack. Could you, please, check them when you have a chance.

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    














        

  
          


  
    
  
  

    
  vbekiaris 

      pushed a commit
      that referenced
      this pull request

    
      Jun 13, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members [5.…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          ee2e3e4
        
      

    

  

    

      
…1.z] (#24668)

Resolves #24635
Backport of #24639

    




    

  




  


  
    
  
  

    
  ahmetmircik 

      pushed a commit
      that referenced
      this pull request

    
      Jun 13, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (#2…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          5409a13
        
      

    

  

    

      
…4639) [5.0.z] (#24667)

Resolves #24635

    




    

  




  


  
    
  
  

    
  ahmetmircik 

      pushed a commit
      that referenced
      this pull request

    
      Jun 13, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (#2…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          b085ec5
        
      

    

  

    

      
…4639) [5.3.z] (#24670)

Resolves #24635

    




    

  




  


  
    
  
  

    
  ahmetmircik 

      pushed a commit
      that referenced
      this pull request

    
      Jun 13, 2023
    
    

      


  

    

      


  

      
        @azotcsit
  





      

        
          Prevent sending empty map interceptors information to new members (#2…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          bab60e0
        
      

    

  

    

      
…4639) [5.2.z] (#24669)

Resolves #24635

    




    

  











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
    @vbekiaris
  
    vbekiaris



          
            
              
            
          
          vbekiaris approved these changes

        

        

          

  
    @ahmetmircik
  
    ahmetmircik



          
            
              
            
          
          ahmetmircik approved these changes

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    Module: IMap

  

    Source: Community

  PR or issue was opened by a community user
  

    Team: Core

  

    Type: Defect









      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      
    
  
    5.4.0
  





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.


  
    
            
        Prevent sending empty map interceptors information to new members





    
  




        
      

    

  
      

  

    

      5 participants
    

    

        
          @azotcsit 
        
          @devOpsHazelcast 
        
          @vbekiaris 
        
          @hz-devops-test 
        
          @ahmetmircik