Support nullable types when reading Avro files [HZ-2507] #24840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, the following statements are affected:
CREATE MAPPING <name> TYPE File OPTIONS ('format'='avro', ...)
TABLE(AVRO_FILE(...))
burakgok
added
Type: Enhancement
Source: Internal
|
Is it a breaking change? |
k-jamroz
approved these changes
Jul 3, 2023
|
This change just enables Avro file mappings and |
frant-hartm
requested changes
Jul 18, 2023
Comment on lines
+190
to
+193
| @Test | ||
| public void test_tableFunction_nullableFields() { | ||
| test_tableFunction(AVRO_NULLABLE_FILE); | ||
| } |
There was a problem hiding this comment.
We are missing test reading nulls. This reads nullable fields, which contain values.
# Conflicts: # hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/connector/keyvalue/KvMetadataAvroResolver.java # hazelcast-sql/src/test/java/com/hazelcast/jet/sql/impl/connector/kafka/SqlAvroTest.java
burakgok
force-pushed
the
fix/5.4/read-nullable-avro-types
branch
from
1b281bc
to
fba7e40
Compare
frant-hartm
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the following statements are affected:
Fixes HZ-2507
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset