Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a flow control to fix exponential backoff behaviour for CP subsystem [HZ-2702] [5.3.z] (#25055) #25074

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Introduce a flow control to fix exponential backoff behaviour for CP subsystem [HZ-2702] [5.3.z] (#25055) #25074

merged 1 commit into from
Jul 26, 2023

Conversation

arodionov
Copy link
Contributor

@arodionov arodionov commented Jul 25, 2023 •
edited

Added flowControlSequenceNumber to Append/InstallSnapshot requests and responses to perform matching between them.
This allows reset the backoff only for the corresponding request.

Fixes #24958

Breaking changes (list specific methods/types/messages):

  • AppendRequest, InstallSnapshot, AppendSuccessResponse,AppendFailureResponse

(cherry picked from commit 8e3ffce)

Backport of: #25055

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@arodionov
Introduce a flow control to fix exponential backoff behaviour for CP …
fef7f17 
…subsystem [HZ-2702] [5.3.z] (hazelcast#25055)

Added `flowControlSequenceNumber` to Append/InstallSnapshot requests and
responses to perform matching between them.
This allows reset the backoff only for the corresponding request.

Fixes hazelcast#24958

Breaking changes (list specific methods/types/messages):
* `AppendRequest`, `InstallSnapshot`, `AppendSuccessResponse`,`AppendFailureResponse`

(cherry picked from commit 8e3ffce)
@arodionov arodionov self-assigned this Jul 25, 2023
@arodionov arodionov added this to the 5.3.z milestone Jul 25, 2023
@arodionov arodionov marked this pull request as ready for review July 25, 2023 19:57
vbekiaris
vbekiaris approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@vbekiaris vbekiaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a compatibility test (on EE side) that starts a bunch of 5.3.0/1/current members and executes CP subsystem ops to ensure compatibility?

@arodionov
Copy link
Contributor Author

arodionov commented Jul 26, 2023 •
edited

Can we add a compatibility test (on EE side) that starts a bunch of 5.3.0/1/current members and executes CP subsystem ops to ensure compatibility?

@vbekiaris Yes, I'll take this

@arodionov arodionov merged commit 0f23576 into hazelcast:5.3.z Jul 26, 2023
8 checks passed
@AyberkSorgun AyberkSorgun modified the milestones: 5.3.z, 5.3.2 Aug 15, 2023
@arodionov arodionov deleted the 5.3.z branch September 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbekiaris vbekiaris vbekiaris approved these changes

@ahmetmircik ahmetmircik ahmetmircik approved these changes

Assignees

@arodionov arodionov

Labels
Add to Release Notes Backport Module: CP Subsystem Source: Internal PR or issue was opened by an employee Team: Core Type: Defect Type: Enhancement Type: Perf. Defect
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arodionov @vbekiaris @ahmetmircik @AyberkSorgun