Update janino to 3.1.10 [5.3.z] #25094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hazelcast#24732 (CVE-2023-33546) in 5.3.z branch. The fix in master should be to update calcite when they update their dependency to 3.1.10.
frant-hartm
added
Source: Internal
TomaszGaweda
approved these changes
Jul 27, 2023
|
run-nightly-tests |
|
^ just to double check if that does not break any SQL IT test |
|
Note that Janino "fixed" the issue by translating StackOverflowException to different exception - does not change anything from the security perspective, only silences the tools. But anyway, Janino should be used only internally to generate some optimizer rules code. AFAIK it is not used to parse SQL statements, for that JavaCC-generated parser is used. |
k-jamroz
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24732 (CVE-2023-33546) in 5.3.z branch.
The fix in
mastershould be to update calcite when they update their dependency to 3.1.10. If they don't publish such version before 5.4 release then we can forward-port this PR.Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset