Avoid parsing internal Debezium messages [HZ-3863] #26027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sages' into 5.4/parsing-fix-for-internal-messages
TomaszGaweda
added
Type: Defect
Source: Internal
orcunc
approved these changes
Nov 27, 2023
orcunc
reviewed
Nov 27, 2023
| @@ -54,7 +54,8 @@ public ChangeRecordCdcSourceP( | |||
| @Nullable | |||
| @Override | |||
| protected ChangeRecord map(SourceRecord record) { | |||
| if (record == null) { | |||
| if (record == null || record.topic().startsWith("__debezium")) { | |||
| // internal Debezium messages about e.g. Heartbeat uses such topics | |||
| return null; | |||
There was a problem hiding this comment.
Another alternative could be
Struct sourceRecordValue = (Struct) sourceRecord.value();
String sourceSchemaName = sourceRecordValue.schema().name();
return sourceSchemaName.startsWith ("io.debezium")There was a problem hiding this comment.
True, it's the same as with value IMHO, so I left only scanning value. But good point :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding e.g. heartbeat config adds messages with value schema's name
io.debezium.connector.common.HeartbeatIt's also under
__debezium*topics, so easy to filter outFixes #26005
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release Noteslabel if changes should be mentioned in release notes orNot Release Notes contentif changes are not relevant for release notes