Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paused Prometheus metric #897

Open
Wouter0100 opened this issue Sep 22, 2023 · 2 comments
Open

Add paused Prometheus metric #897

Wouter0100 opened this issue Sep 22, 2023 · 2 comments
Labels

Comments

@Wouter0100
Copy link

Would there be any interest for a "paused" metric? This way we're able to exclude paused healthchecks in alerts and make it visible in dashboards.

@cuu508
Copy link
Member

cuu508 commented Sep 22, 2023

Can you describe it a little more – how would it look in the metrics endpoint's output, and how would it be used?

@Wouter0100
Copy link
Author

Sure thing, I was thinking of 2 options:

  • Introduce a third state (2) for the hc_check_up field, which shows it being "paused". That would result in:
# HELP hc_check_up Whether the check is currently up (1 for yes, 0 for no, 2 for paused).
# TYPE hc_check_up gauge
hc_check_up{name="Cloud storage backup", tags="", unique_key="hash"} 2
  • Introduce a new hc_check_paused line, e.g.:
# HELP hc_check_paused Whether the check is currently paused (1 for yes, 0 for no).
# TYPE hc_check_paused gauge
hc_check_paused{name="Cloud storage backup", tags="", unique_key="hash"} 1

Especially as hc_check_started was also introduced in a MR, I'd say the last option. We should be able to use this on Grafana dashboards to indicate that the job is paused.

@cuu508 cuu508 added the feature label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants