Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable integration auto-assign per project #903

Open
apollo13 opened this issue Oct 6, 2023 · 2 comments
Open

Allow configurable integration auto-assign per project #903

apollo13 opened this issue Oct 6, 2023 · 2 comments
Labels

Comments

@apollo13
Copy link
Contributor

apollo13 commented Oct 6, 2023

I'd like to add a setting to project which configures the auto assignment of integrations to all available checks. It could be a simple boolean on the project settings page. Would you like to see that feature?

@cuu508
Copy link
Member

cuu508 commented Oct 25, 2023

Thanks for the suggestion.

I'd like to avoid adding modes to interfaces as much as possible, so I've been thinking about alternatives.

The Management API users can already specify a channels key when creating a new check, so they can set the default value on the client side.

For Ping API, and auto-provisioning, the "should we assign all integrations" flag could perhaps go in the URL:

# If a check with slug "sample-slug" does not exist, create it and assign all channels 
GET /sample-ping-key/sample-slug/?create=1

# If a check with slug "sample-slug" does not exist, create it but do not assign any channels
GET /sample-ping-key/sample-slug/?create=1&channels=

(and perhaps more configuration options could go there in future)

For the web interface, we could add a checkbox in the "Add Check" dialog. Checked by default to match the current default, but the user can uncheck it:

image

@apollo13
Copy link
Contributor Author

Ah yes, a checkbox there would do. There is another instance though where such a checkbox would probably be useful, namely when creating an integration/channel it is assigned to all checks as well:
https://github.com/apollo13/healthchecks/blob/e546a1325ba04a2c74ea16accae8ed79b2185505/hc/front/views.py#L1284

Since this affects existing checks I'd like to have a way to prevent that as well (a checkbox would do I guess).

@cuu508 cuu508 added the feature label Dec 15, 2023
@cuu508 cuu508 changed the title [feature] Allow configurable integration auto-assign per project Allow configurable integration auto-assign per project Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants