Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator class don't uses GeneratorInterface #360

Open
edysmp opened this issue Jul 12, 2019 · 1 comment
Open

Generator class don't uses GeneratorInterface #360

edysmp opened this issue Jul 12, 2019 · 1 comment

Comments

@edysmp
Copy link

edysmp commented Jul 12, 2019

I see we have a GeneratorInterface but we don't use it, at least in Generator class.

I am creating a command which uses Generator feature, the generate:command by defualt set to use \Drupal\Console\Core\Generator\GeneratorInterface as paramater signature of my Command class. I get a TypeError like: MyGeneratorClass must implement interface GeneratorInterface.

@edysmp
Copy link
Author

edysmp commented Jul 12, 2019

I fix this error whe i implements GeneratorInterface in my CustomGenerator. I see that generate:command generates this by default. But still should we implement this interface in the base Generator class instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant