Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Generators commands from ExtensionManager #3966

Open
LOBsTerr opened this issue Oct 22, 2018 · 2 comments
Open

Clean up Generators commands from ExtensionManager #3966

LOBsTerr opened this issue Oct 22, 2018 · 2 comments

Comments

@LOBsTerr
Copy link
Member

Issue title

Because we moved the Code of Generators to separate service in many cases ExtensionManager is not used any more

Solution

Remove extension managers from the definition of the commands and constructors

@LOBsTerr
Copy link
Member Author

PR #3968

@jmolivas

  1. I propose create a new class ModuleAwareCommand, which will be a Base classes for the commands, which generate the code inside of a module.
  2. Like this we get rid off Module trait
  3. All these commands are using the same traits, the same methods and fields

If you will confirm this idea, I will continue and will convert the code

@enzolutions
Copy link
Contributor

@LOBsTerr I think this is a good idea, could you continue with this approach to be included in Drupal Console 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants