Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config:override] Changes values in active storage instead of "overriding" it #3543

Open
Aluquot opened this issue Oct 12, 2017 · 0 comments · May be fixed by #4120
Open

[config:override] Changes values in active storage instead of "overriding" it #3543

Aluquot opened this issue Oct 12, 2017 · 0 comments · May be fixed by #4120

Comments

@Aluquot
Copy link

Aluquot commented Oct 12, 2017

Problem/Motivation

When using the config:override command I noticed that it actually writes the settings into the active storage. When reading the command name & description I actually expected to be "real overrides" as Drupal supports them. But those would be placed into the / a settings.*.php file.
The benefit of real overrides is that their value are not exported when doing a config export.

As it stands the current functionalit is more like a config:set instead of an override.

How to reproduce

  1. Install Drupal with standard install profile.
  2. Export configuration to the sync folder
  3. Set a cofig override via config:override
  4. Go to the Configuration Sync page & see that the value is actually changed by the override because it differs from the exported one

Additional notes:

  • Drupal version: 8.4.0
  • Console versio: 1.0.0

Solution

  1. Rename to 'config:set' to make say what it does
  2. [optional] Implement 'config:override' in such a way that it actually is a Drupal-Override. The easiest might be to seperat 'overrides' into their own settings file that is setup to be includes by the settings.php.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants