Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material typography V2 #21

Open
colmbrady opened this issue Sep 19, 2018 · 6 comments
Open

Material typography V2 #21

colmbrady opened this issue Sep 19, 2018 · 6 comments

Comments

@colmbrady
Copy link

Material design has updated its typography definitions.

any plans to mirror that in this library?

@hectahertz
Copy link
Owner

Definitely!

@colmbrady
Copy link
Author

Any guiding principles for starting this work? Id be open to contributing this work.

Any ideas on how you want to version the Material typography? e.g. materialOld.js ..?

@hectahertz
Copy link
Owner

The updated scale is quite different, so probably some of the users won't want to migrate to the new scale right away.

Having that in mind, I think that we should aim for:

  • A solution for the users that want to keep using the old scale for now and migrate their styles manually
  • A way for users to switch to the new scale immediately
  • Not introducing complexity for new users that are only interested in the new scale

Material UI took an interesting approach, see: https://material-ui.com/style/typography/#migration-to-typography-v2

I also recommend reading the RFC: mui/material-ui#12741

We could go for a similar solution, what do you think?

@LRNZ09
Copy link

LRNZ09 commented Dec 24, 2019

Similar issue here #34

@FRizzonelli
Copy link

@hectahertz Any news on this?

@ha3
Copy link

ha3 commented Aug 21, 2021

@hectahertz hello, thank you for the great work! Are you still planning to work on this? I also wonder if iOS styles are still relevant or they need to be updated as well (for example, according to official resources, largeTitleEmphasized seems to have letterSpacing value of 0.37 but definitions show 0.41).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants