Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match the dark theme with the one used by GitHub #22

Open
faheel opened this issue Feb 12, 2021 · 3 comments
Open

Match the dark theme with the one used by GitHub #22

faheel opened this issue Feb 12, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@faheel
Copy link

faheel commented Feb 12, 2021

The dark theme used in this extension is different from the one used by GitHub. It would be great if they both matched!

Also, when the dark mode is enabled, there is a white border around the editor which doesn't look good.

Screenshot from 2021-02-12 21-23-28

Screenshot from 2021-02-12 21-23-39
@faheel
Copy link
Author

faheel commented Feb 12, 2021

The defineTheme method can be used for this.

@hediet hediet added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 12, 2021
@hediet
Copy link
Owner

hediet commented Feb 12, 2021

That would be a nice addition indeed!
I won't find time for this in the next couple of months though. I welcome PRs!

@faheel
Copy link
Author

faheel commented Feb 12, 2021

I'll dig into this more over the weekend. Hopefully I'll be able to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hediet @faheel