Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab title changes to "(Draft comment)" when comment box is empty #36

Open
tech189 opened this issue Nov 4, 2021 · 3 comments
Open

Tab title changes to "(Draft comment)" when comment box is empty #36

tech189 opened this issue Nov 4, 2021 · 3 comments

Comments

@tech189
Copy link

tech189 commented Nov 4, 2021

If you leave an issue or pull request page open in the background, the tab title will immediately change to "(Draft comment) ..." even if the user hasn't typed anything in the comment box.

This does not happen when the addon is disabled.

@fregante
Copy link

fregante commented Mar 9, 2023

Note that this is due to Refined GitHub (but won't be fixed there since it's due to an external cause)

https://github.com/refined-github/refined-github/blob/main/source/features/unfinished-comments.tsx

@hediet
Copy link
Owner

hediet commented Mar 13, 2023

@fregante is this extension the external cause? Do you know why this happens?

@fregante
Copy link

This is the condition that determines whether there's a "draft comment":

https://github.com/refined-github/refined-github/blob/1cef9d43cc5990c6aed55b01508297b347c8a261/source/features/unfinished-comments.tsx#L14

I don't know exactly what part of Monaco is causing that condition to become true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants