Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an LRU cache #33

Open
hegemonic opened this issue Aug 7, 2014 · 1 comment
Open

Use an LRU cache #33

hegemonic opened this issue Aug 7, 2014 · 1 comment
Assignees

Comments

@hegemonic
Copy link
Owner

For efficiency, Catharsis caches all of its parse results. Right now it caches all parse results indefinitely, which is not appropriate for a long-running process. Catharsis should use an LRU cache instead.

@hegemonic hegemonic self-assigned this Aug 7, 2014
@hegemonic
Copy link
Owner Author

I've never verified that caching the parse results is actually faster than re-parsing the type expression. So before I add an LRU cache, I need to run some quick benchmarks of the following:

  • Current implementation with caching
  • Current implementation with caching, but using sigmund to generate the cache key
  • Current implementation with caching disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant