Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Deprecate this module on NPM? #1

Closed
broofa opened this issue May 13, 2021 · 4 comments
Closed

Deprecate this module on NPM? #1

broofa opened this issue May 13, 2021 · 4 comments

Comments

@broofa
Copy link

broofa commented May 13, 2021

Given that "all the code in this package comes from the uuid project" can I politely suggest that you npm deprecate this module? With a message to the effect of, "Use the uuid module instead"?

One specific reason for this is that the code you're publishing is known to have issues due to it's use of Math.random(). The official uuid project stopped using Math.random() several versions ago for this reason.

@broofa
Copy link
Author

broofa commented Apr 3, 2023

[Closing out issues I've authored that appear to be stagnant.]

@broofa broofa closed this as completed Apr 3, 2023
@SimenB
Copy link

SimenB commented May 15, 2023

@heikomat might be worth doing this - the module has 3.5M downloads a week (@storybook/addon-actions has now migrated over to uuid, so that number is likely to stop growing. But still 🙂)

@heikomat
Copy link
Owner

What the heck?
Sorry for not anwering @broofa, must have missed the email.
And @SimenB you're 100% correct, i should deprecate this.

I just needed some uuids in a browser 6 years ago and then forgot about this package. People should NOT be using it.
It has never been updated and there are better alternatives by now

  1. Browsers can now natively create v4 uuids: https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID
  2. The original uuid-package this is copied from exports proper browser-builds since version 7.0.1

Will deprecate it sometime this week

@heikomat heikomat reopened this May 15, 2023
@heikomat
Copy link
Owner

I npm deprecated the package and added a deprecation-message to the readme.

Will now archive the repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants