Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A slide can be skipped even if navigation is blocked #306

Open
tutaf opened this issue Jan 3, 2021 · 1 comment
Open

A slide can be skipped even if navigation is blocked #306

tutaf opened this issue Jan 3, 2021 · 1 comment
Labels

Comments

@tutaf
Copy link

tutaf commented Jan 3, 2021

A long swipe skips slide that should be unskippable

Reproduce

Steps to reproduce the behavior:

  1. Open demo app (or other app with this library)
  2. Click on "start intro"
  3. Scroll to an unskippable slide (eg. permission request or login)
  4. Long swipe several times
  5. Slide is skipped

Expected behavior

The slide shouldn't be skipped

Stack trace / screenshots

MNML-January3-113943PM.mp4

Device

Asus Zenfone Max Pro M1 (Android 10), demo app v.1.6.1 (same problem in library v.2.0.0)
Emulator (Pixel 3a, API 30) library version v.2.0.0

@tutaf tutaf added the bug label Jan 3, 2021
@heinrichreimer
Copy link
Owner

This is a glitch which I was not able to fix in ViewPager, as the stock ViewPager API does not support blocking swiping. Thus I had to block swiping using touch listeners. I would be happy to merge a PR in that regard, but I don't have the time to re-implement blocking of sliding. Maybe the library needs to be re-written with ViewPager2...
PS: Turns out, GitHub quick-tips just told me you can upload MP4 and MOV files by drag & drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants