edit-command-line bug

[Randalix]

Summary

If you set helix as EDITOR and run the shortcut for edit-command-line: main' panicked at 'reader source not set'
Tested with zsh and helix 22.12 (3e68876)

Error Message:

'main' panicked at 'reader source not set', /Users/joe/.cargo/registry/src/github.com-1ecc6299db9ec823/crossterm-0.25.0/src/event/read.rs:38:9
stack backtrace:
   0:        0x104afd518 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h71d20ef014883dc3
   1:        0x104310948 - core::fmt::write::hd114a9636e34e383
   2:        0x104ae72a4 - std::io::Write::write_fmt::h05898edc92938c00
   3:        0x104aed8d8 - std::panicking::default_hook::{{closure}}::hbd40827d346a3df4
   4:        0x104aed328 - std::panicking::default_hook::hf2e0d2c157a06c84
   5:        0x104aee0c8 - std::panicking::rust_panic_with_hook::h33fd2dae40c879df
   6:        0x104afdbb8 - std::panicking::begin_panic_handler::{{closure}}::h81ef06081ce645db
   7:        0x104afd648 - std::sys_common::backtrace::__rust_end_short_backtrace::hc514eeb5ddb8eaf3
   8:        0x104aedcfc - _rust_begin_unwind
   9:        0x104b91f30 - core::panicking::panic_fmt::h520fb0ef56e6cee7
  10:        0x10430d24c - core::panicking::panic_display::h7619df031086fcb5
  11:        0x10430d210 - core::panicking::panic_str::h15803e8ee1ccc3e5
  12:        0x104b91d84 - core::option::expect_failed::h8a51966424cdb16b
  13:        0x10432019c - <crossterm::event::stream::EventStream as core::default::Default>::default::hc6fde78d039293a4
  14:        0x10497efc0 - <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha58280172b823966
  15:        0x1049b5ab0 - tokio::runtime::park::CachedParkThread::block_on::h7f5a5b3b557ab2f9
  16:        0x1049d5aa8 - tokio::runtime::scheduler::multi_thread::MultiThread::block_on::hb8334b9d179f83fa
  17:        0x1049de320 - tokio::runtime::runtime::Runtime::block_on::he272d0df512fa0b4
  18:        0x104981700 - hx::main::h36dd58a0f4e77b6d
  19:        0x1049c07ec - std::sys_common::backtrace::__rust_begin_short_backtrace::h7bbfec154fef7258
  20:        0x1049720bc - std::rt::lang_start::{{closure}}::hc1b9481f1c826de0
  21:        0x104aebf64 - std::rt::lang_start_internal::h3f58ab0124dae34f
  22:        0x104981810 - _main

Reproduction Steps

My Zsh Conf:
autoload edit-command-line; zle -N edit-command-line
bindkey '^h' edit-command-line
export VISUAL=hx

I expected this to happen:
If I press ctrl-h I can edit the command in helix.

Instead, this happened:
main' panicked at 'reader source not set'

Helix log

~/.cache/helix/helix.log

2022-12-31T12:13:52.662 helix_lsp::transport [ERROR] err: <- IO(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" })

Platform

macOS

Terminal Emulator

kitty

Helix Version

helix 22.12 (3e68876)

[the-mikedavis]

This is the same problem as #2111 so I will close in favor of that issue. It needs a fix upstream in crossterm but that is being actively worked on in crossterm-rs/crossterm#735

[mattmc3]

I ran into this bug today as well trying to switch my Zsh line editor to Helix. The PR referenced (crossterm-rs/crossterm#735) got merged last week. Should that fix be reflected in Helix yet, or is this still unresolved?

[the-mikedavis]

See the linked PR for #2111: #5468

We're waiting on a crossterm release