Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVersion treated as decimal number #362

Open
endriu0 opened this issue Dec 22, 2023 · 0 comments
Open

AppVersion treated as decimal number #362

endriu0 opened this issue Dec 22, 2023 · 0 comments

Comments

@endriu0
Copy link

endriu0 commented Dec 22, 2023

Hey, Thanks for the awesome tool - one issue that I wanted to raise as didn't see anything about it in the repo is that appVersion sometimes gets treated as a decimal number instead of string due to not being quoted.

This requires specific circumstances - e.g. in our case using commit id as appVersion and bad luck - e.g this is the commit that started breaking our index file 02824e16 but I guess this could be worked around by quoting the appVersion field automatically.

I've checked all of our releases and they all have appVersion quoted in Chart.yaml therefore chart-releaser must be dropping it when copying the info.

Not able to find where this gets created in the code but I found the same issue on the upstream helm3 repo as an example : helm/helm#6849

@endriu0 endriu0 changed the title AppVersion treated as floating point AppVersion treated as decimal number Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant