Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting steps to CI (github actions) #569

Open
cbuto opened this issue Mar 24, 2022 · 3 comments
Open

Add linting steps to CI (github actions) #569

cbuto opened this issue Mar 24, 2022 · 3 comments
Assignees

Comments

@cbuto
Copy link
Contributor

cbuto commented Mar 24, 2022

We should introduce linting checks as a part of our CI process that are ran on both PRs and the main branch.

    • Resolve linting failures that currently exist (either fix or add skips)
    • Add a linting step to github actions that runs on PRs and main. The official golangci-lint action will comment on PRs making it easier to surface issues, that might be the way to go.

The linting failures can be worked overtime as long as they are all resolved before linting is added to GitHub actions.

@hydeenoble
Copy link

Hey, @cbuto I would like to pick up this issue.

@nerdeveloper
Copy link
Member

Sure please, go ahead and pick it up. I was supposed to work on it but my hands are full right now. Let us follow if you have any follow up questions

@hydeenoble
Copy link

Awesome, Thanks @nerdeveloper. you can also assign the issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants