Skip to content

Commit a23dd9e

Browse files
committedMar 11, 2024··
Add a note about --dry-run displaying secrets
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 parent 32f3691 commit a23dd9e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed
 

‎cmd/helm/install.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,11 @@ And in the following example, 'foo' is set to '{"key1":"value1","key2":"bar"}':
9494
$ helm install --set-json='foo={"key1":"value1","key2":"value2"}' --set-json='foo.key2="bar"' myredis ./redis
9595
9696
To check the generated manifests of a release without installing the chart,
97-
the '--debug' and '--dry-run' flags can be combined.
97+
the --debug and --dry-run flags can be combined.
98+
99+
The --dry-run flag will output all generated chart manifests, including Secrets
100+
which can contain sensitive values. Please carefully consider how and when this
101+
flag is used.
98102
99103
If --verify is set, the chart MUST have a provenance file, and the provenance
100104
file MUST pass all verification steps.

‎cmd/helm/upgrade.go

+4
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ parameters, and existing values will be merged with any values set via '--values
7272
or '--set' flags. Priority is given to new values.
7373
7474
$ helm upgrade --reuse-values --set foo=bar --set foo=newbar redis ./redis
75+
76+
The --dry-run flag will output all generated chart manifests, including Secrets
77+
which can contain sensitive values. Please carefully consider how and when this
78+
flag is used.
7579
`
7680

7781
func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {

0 commit comments

Comments
 (0)
Please sign in to comment.