Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can --post-renderer support assign the cmd args into executable ? #10511

Closed
tanguofu opened this issue Dec 30, 2021 · 2 comments · Fixed by #10514
Closed

can --post-renderer support assign the cmd args into executable ? #10511

tanguofu opened this issue Dec 30, 2021 · 2 comments · Fixed by #10514
Labels

Comments

@tanguofu
Copy link

now helm --post-renderer only accept the executable in PATH;

but it is very necessary that the post-renderer-executable worked with some args ,for example change the docker.io registry into private docker registry when deploy the chart without internet access.

can helm can add args to assign the args in to post-renderer-executable such as --post-renderer-args

helm install mychart stable/wordpress --post-renderer ./path/to/render_executable --post-renderer-args "--args_to_render_executable  "

if this proposal be ok, i d like to contribute a PR.

@marckhouzam
Copy link
Member

I believe this is a good idea. It was discussed before in #9047 where you will find some guidance on dealing with backwards-compatibility.

But for those not aware, the current way to pass arguments to the post-renderer is to write a little executable shell script that calls the post-renderer with the arguments, and have helm call that script.

@tanguofu
Copy link
Author

tanguofu commented Jan 5, 2022

@marckhouzam could u review this PR: #10514, many thanks

hickeyma added a commit that referenced this issue Jan 31, 2022
fea(#10511): add --post-renderer-args to support assign args to PostR…
mrubeljTN pushed a commit to true-north-engineering/helm that referenced this issue Feb 2, 2022
…ostRenderer exec

Signed-off-by: guofutan <guofutan@tencent.com>
zak905 pushed a commit to zak905/helm that referenced this issue Jan 19, 2023
…ostRenderer exec

Signed-off-by: guofutan <guofutan@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants