Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindChartInAuthAndTLSAndPassRepoURL doesn't clean up temp files #11171

Closed
crenshaw-dev opened this issue Jul 21, 2022 · 0 comments · Fixed by #11172
Closed

FindChartInAuthAndTLSAndPassRepoURL doesn't clean up temp files #11171

crenshaw-dev opened this issue Jul 21, 2022 · 0 comments · Fixed by #11172
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@crenshaw-dev
Copy link

The issue is in Helm v3.8.0. During a helm pull in Argo CD looking for a chart version that no longer exists, FindChartInAuthAndTLSAndPassRepoURL downloads two temporary files (with randomized names) and then does not clean them up. This is resulting in disks filling up in Argo CD, which regularly re-attempts the helm pull to try to get the Application in sync.
crenshaw-dev pushed a commit to crenshaw-dev/helm that referenced this issue Jul 21, 2022
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (helm…
4273bd2 
…#11171)
crenshaw-dev pushed a commit to crenshaw-dev/helm that referenced this issue Jul 21, 2022
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (helm…
0ae87e7 
…#11171)
@crenshaw-dev crenshaw-dev mentioned this issue Jul 21, 2022
Merged
3 tasks
crenshaw-dev pushed a commit to crenshaw-dev/helm that referenced this issue Jul 21, 2022
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (helm…
24fa3d9 
…#11171)

Signed-off-by: CI <ci@argoproj.com>
@yxxhero yxxhero added the bug Categorizes issue or PR as related to a bug. label Jul 22, 2022
@crenshaw-dev crenshaw-dev mentioned this issue Aug 15, 2022
Open
3 tasks
mattfarina added a commit that referenced this issue Oct 11, 2022
@mattfarina
Merge pull request #11172 from crenshaw-dev/cleanup-after-find-chart
90a2575 
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (#11171)
mattfarina pushed a commit that referenced this issue Oct 12, 2022
@mattfarina
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (#11171)
f6830f7 
Signed-off-by: CI <ci@argoproj.com>
(cherry picked from commit 24fa3d9)
zak905 pushed a commit to zak905/helm that referenced this issue Jan 19, 2023
@zak905
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (helm…
8c16620 
…#11171)

Signed-off-by: CI <ci@argoproj.com>
@commit-lint commit-lint bot mentioned this issue May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (#11171) crenshaw-dev/helm
2 participants
@crenshaw-dev @yxxhero