Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm is unable to update if the previous deployment failed #13017

Open
whober0521 opened this issue May 8, 2024 · 2 comments
Open

Helm is unable to update if the previous deployment failed #13017

whober0521 opened this issue May 8, 2024 · 2 comments

Comments

@whober0521
Copy link

Output of helm version:

version.BuildInfo{Version:"v3.14.4", GitCommit:"81c902a123462fd4052bc5e9aa9c513c4c8fc142", GitTreeState:"clean", GoVersion:"go1.21.9"}

Output of kubectl version:

Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.5

Cloud Provider/Platform (AKS, GKE, Minikube etc.): AKS

Hi, I ran an issue that helm is unable to update if the previous deployment failed, the following is my steps:

  1. Deploy healthy pod and secret provider

    • Helm upgrade succeed
    • Pod and Secret Provider class are synced
  2. Break the pod and update secret provider class

    • Helm upgrade failed on pod
    • Pod and Secret Provider class are synced
  3. Update secret provider class

    • Helm upgrade failed on pod
    • Pod is synced
    • Secret Provider class is updated in helm get but not updated in kubectl describe
@gjenkins8
Copy link
Contributor

If external modifications are made to an object , Helm doesn't necessarily overwrite these. See: https://helm.sh/docs/faq/changes_since_helm2/#improved-upgrade-strategy-3-way-strategic-merge-patches

(I suspect this is what is happening here)

Otherwise for brevity, a more succinct replication example will be needed please.

@whober0521
Copy link
Author

Hi, @gjenkins8 , there is no external modifications. I only ran helm update in these steps, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants