Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: README.md shows expectCt() being set by default #397

Closed
thernstig opened this issue Jan 31, 2023 · 2 comments
Closed

Docs: README.md shows expectCt() being set by default #397

thernstig opened this issue Jan 31, 2023 · 2 comments

Comments

@thernstig
Copy link
Contributor

Helmet 6.0.0 says that helmet.expectCt() is no longer set by default, as it was changed here #310

This still shows it being set though:

helmet/README.md

Line 99 in 151a7c5

app.use(helmet.expectCt());

@thernstig thernstig mentioned this issue Jan 31, 2023
Closed
@EvanHahn
Copy link
Member

Thanks for reporting. I'll take a look at your PR soon.

EvanHahn pushed a commit that referenced this issue Feb 2, 2023
@thernstig @EvanHahn
Update docs: expectCt is no longer set by default
a276e60 
Helmet v6 stopped including `expectCt` by default, but the README still
mentioned it.

See [#397][0] and [#398][1].

[0]: #397
[1]: #398
@EvanHahn
Copy link
Member

EvanHahn commented Feb 2, 2023

This was fixed in a276e60. Thanks for reporting!

@EvanHahn EvanHahn closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove helmet.expectCt() from README.md thernstig/helmet
2 participants
@EvanHahn @thernstig