Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict-Transport-Security: Remove includeSubdomains (lowercase d) #231

Closed
EvanHahn opened this issue Mar 10, 2019 · 1 comment
Closed

Strict-Transport-Security: Remove includeSubdomains (lowercase d) #231

EvanHahn opened this issue Mar 10, 2019 · 1 comment
Assignees
@EvanHahn

Comments

@EvanHahn
Copy link
Member

The includeSubdomains option (with a lowercase d) will be removed in hsts@3 and helmet@4. Use the includeSubDomains option (with a capital D) instead.

Old:

app.use(hsts({
  maxAge: 15552000,
  includeSubdomains: false
}))

New:

app.use(hsts({
  maxAge: 15552000,
  includeSubDomains: false
}))

Diff:

- includeSubdomains: false
+ includeSubDomains: false
@EvanHahn EvanHahn self-assigned this Mar 10, 2019
EvanHahn referenced this issue in helmetjs/hsts Mar 10, 2019
@EvanHahn
Deprecate includeSubdomains (lowercase d)
1b1e104 
See <https://github.com/helmetjs/hsts/issues/21>.
EvanHahn referenced this issue in helmetjs/hsts Sep 1, 2019
@EvanHahn
Drop support for Node <8; change maxAge: null behavior; remove deprec…
2cb4cc5 
…ated options

Closes #21.
Closes #22.
Closes #26.
EvanHahn referenced this issue in helmetjs/hsts Apr 12, 2020
@EvanHahn
Drop support for Node <8; change maxAge: null behavior; remove deprec…
9323213 
…ated options

Closes #21.
Closes #22.
Closes #26.
@EvanHahn EvanHahn transferred this issue from helmetjs/hsts Jul 10, 2020
@EvanHahn EvanHahn changed the title Remove includeSubdomains (lowercase d) Strict-Transport-Security: Remove includeSubdomains (lowercase d) Jul 10, 2020
@EvanHahn EvanHahn mentioned this issue Jul 10, 2020
Merged
36 tasks
@EvanHahn
Copy link
Member Author

Addressed in 788d69b. To be released in version 4 (see #197).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop setIf and includeSubdomains options gzog/hsts
1 participant
@EvanHahn