Bug: Incompatibility of MockComponent with new viewChild signal function #8634
Assignees
Labels
bug
Something isn't working
Comments
|
I can confirm this one 👍 Having same problems after the change. |
|
Temporary workaround: use @Component({
selector: 'app-nested',
standalone: true,
template: ``,
})
class NestedComponentStub {
public readonly anchor = signal(new ElementRef(undefined)).asReadonly();
public readonly name = input.required<string>();
}
describe('my sandbox', () => {
beforeEach(() =>
MockBuilder(TargetComponent).replace(NestedComponent, NestedComponentStub)
); |
|
@satanTime this seems to be a better fix: simply remove the view queries, as they’ll always be null anyway ng-mocks/libs/ng-mocks/src/lib/common/decorate.queries.ts Lines 22 to 39 in 282cbf0 const generateFinalQueries = (queries: {
[key: string]: Query;
}): [Array<[string, Query & { ngMetadataName?: string }]>, string[]] => {
const final: Array<[string, Query & { ngMetadataName?: string }]> = [];
const scanKeys: string[] = [];
for (const key of Object.keys(queries)) {
const query: Query & { ngMetadataName?: string } = queries[key];
- final.push([key, query]);
if (!query.isViewQuery && !isInternalKey(key)) {
+ final.push([key, query]);
scanKeys.push(key);
final.push([`__ngMocksVcr_${key}`, cloneVcrQuery(query)]);
}
}
return [final, scanKeys];
}; |
c-harding
added a commit
to c-harding/ng-mocks
that referenced
this issue
Apr 16, 2024
ViewChild will always be null, and so there is no point in mocking it. viewChild.required throws an error in mocked components without this change. Fixes help-me-momGH-8634
c-harding
added a commit
to c-harding/ng-mocks
that referenced
this issue
Apr 16, 2024
ViewChild will always be null, and so there is no point in mocking it. viewChild.required throws an error in mocked components without this change. Fixes help-me-momGH-8634
|
This will be fixed by the same fix as #7976, is my guess. |
|
Good evening, any news? |
|
Hello, any updates on this issue? |
|
I guess #8895 is a similar problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
Testing standalone components with nested components that use the new viewChild signal feature is currently not possible if the nested component should be mocked.
I'm not sure if ngMocks can do anything about it or if its an angular-core related problem.
An example of the bug
Link: https://stackblitz.com/edit/github-6eneyd?file=src%2Ftest.spec.ts
I added a "NestedComponent" to the default example and replaced the module-based definitions with a simple standalone definition.
Expected vs actual behavior
Using the Signal implementation leads to
TypeError: Cannot read properties of undefined (reading 'Symbol(SIGNAL)')Switching the implementation from Signal to Decorator lets test run fine,
The text was updated successfully, but these errors were encountered: