Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag end triggers the onClick handler on mobile #79

Open
alejo4373 opened this issue Aug 16, 2021 · 0 comments
Open

Drag end triggers the onClick handler on mobile #79

alejo4373 opened this issue Aug 16, 2021 · 0 comments

Comments

@alejo4373
Copy link

alejo4373 commented Aug 16, 2021

This is because the handleClick handler is being passed to the onTouchEnd prop in the file below.

onTouchEnd={handleClick}

This is specially an issue when there's not enough vertical space to fit the full height of the calendar on mobile (because of the mobile browser address bar at the top and navigation bar at the bottom, in this case). The user will try to scroll down to click one of the last dates of the month for example triggering the click event will the CalendarDay that was initially held for the drag up movement

💡 This is only an issue when touchDragEnabled is set to false. I could look more into it and submit a PR with a potential fix, if yo want me to.

RPReplay_Final1629083527.MP4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant