From b838c9230bafdd989f4602cc393b188f7244698d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:42:02 -0500 Subject: [PATCH 01/12] spelling: arbiters Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5d0235b282..df1dc9dc8d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ This page lists the operational governance model of this project, as well as the ## Salesforce Sponsored -The intent and goal of open sourcing this project is to increase the contributor and user base. However, only Salesforce employees will be given `admin` rights and will be the final arbitrars of what contributions are accepted or not. +The intent and goal of open sourcing this project is to increase the contributor and user base. However, only Salesforce employees will be given `admin` rights and will be the final arbiters of what contributions are accepted or not. # Issues, requests & ideas From 32fd83732fdbc20990d304be6356a467c23f043b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:46:33 -0500 Subject: [PATCH 02/12] spelling: errors Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/ci-v5/test/unit/lib/disambiguate.unit.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ci-v5/test/unit/lib/disambiguate.unit.test.js b/packages/ci-v5/test/unit/lib/disambiguate.unit.test.js index b97a4da7ed..4ac87d1345 100644 --- a/packages/ci-v5/test/unit/lib/disambiguate.unit.test.js +++ b/packages/ci-v5/test/unit/lib/disambiguate.unit.test.js @@ -25,7 +25,7 @@ describe('disambiguate', function () { api.done() }) - it('erros when no pipelines are returned', async function () { + it('errors when no pipelines are returned', async function () { const api = nock('https://api.heroku.com') .get('/pipelines?eq[name]=notUUID') .reply(200, []) From 8b0005ece8316e344a6e848cf131c3cb470db4e3 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:23:10 -0500 Subject: [PATCH 03/12] spelling: from Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/workflows/get-signed-from-stampy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/get-signed-from-stampy.yml b/.github/workflows/get-signed-from-stampy.yml index 69c102582b..eb39e297bd 100644 --- a/.github/workflows/get-signed-from-stampy.yml +++ b/.github/workflows/get-signed-from-stampy.yml @@ -8,7 +8,7 @@ jobs: environment: Stampy steps: - uses: actions/checkout@v3 - - name: download signed Windows installer from from Stampy + - name: download signed Windows installer from Stampy env: STAMPY_ARN: ${{ secrets.STAMPY_ARN }} AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}} From f802fb6645b446dd43249ef685c7d4beb775d7ed Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:27:57 -0500 Subject: [PATCH 04/12] spelling: functionality Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/cli/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/tsconfig.json b/packages/cli/tsconfig.json index 49e4efb725..bd91617d27 100644 --- a/packages/cli/tsconfig.json +++ b/packages/cli/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "allowJs": true, // allowed to support run-foreman.js. Should be removed when that funcitonality is refactored. + "allowJs": true, // allowed to support run-foreman.js. Should be removed when that functionality is refactored. "declaration": true, "forceConsistentCasingInFileNames": true, "importHelpers": true, From aad129320caf4fd63fa054fd80df6aa9f97cfa28 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:23:27 -0500 Subject: [PATCH 05/12] spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/workflows/start-gh-release.yml | 2 +- .github/workflows/start-prerelease.yml | 2 +- .../workflows/tag-create-github-release.yml | 4 ++-- .../cli/src/lib/pipelines/kolkrabbi-api.ts | 2 +- .../commands/pipelines/connect.unit.test.ts | 2 +- .../unit/commands/pipelines/diff.unit.test.ts | 22 +++++++++---------- scripts/postrelease/change_management | 2 +- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/start-gh-release.yml b/.github/workflows/start-gh-release.yml index a9313e6c3a..d1941fd111 100644 --- a/.github/workflows/start-gh-release.yml +++ b/.github/workflows/start-gh-release.yml @@ -1,4 +1,4 @@ -name: Watch for and start Github Release +name: Watch for and start GitHub Release on: pull_request_target: diff --git a/.github/workflows/start-prerelease.yml b/.github/workflows/start-prerelease.yml index e8738cec71..e946e159d1 100644 --- a/.github/workflows/start-prerelease.yml +++ b/.github/workflows/start-prerelease.yml @@ -48,7 +48,7 @@ jobs: run: | git config user.name "GitHub Actions Bot" git config user.email "heroku-front-end+npm-releases@salesforce.com" - - name: publish tag to Github + - name: publish tag to GitHub run: | git tag "${{ env.TAG_NAME }}" -m "${{ env.TAG_NAME }}" git push origin "${{ env.TAG_NAME }}" diff --git a/.github/workflows/tag-create-github-release.yml b/.github/workflows/tag-create-github-release.yml index 1d9fed8a14..c700f93b0e 100644 --- a/.github/workflows/tag-create-github-release.yml +++ b/.github/workflows/tag-create-github-release.yml @@ -1,4 +1,4 @@ -name: Create Github Release & Tag version in Git +name: Create GitHub Release & Tag version in Git on: workflow_dispatch: @@ -31,7 +31,7 @@ jobs: - name: Create & Push Git Tag run: ./scripts/release/create-git-tag-and-push shell: bash - - name: Release to Github + - name: Release to GitHub # the script below will fail if run from a separate shell file run: | PACKAGE_VERSION=$(node -e "console.log(require('./lerna.json').version)") diff --git a/packages/cli/src/lib/pipelines/kolkrabbi-api.ts b/packages/cli/src/lib/pipelines/kolkrabbi-api.ts index 5fec47dad9..b504f76a5d 100644 --- a/packages/cli/src/lib/pipelines/kolkrabbi-api.ts +++ b/packages/cli/src/lib/pipelines/kolkrabbi-api.ts @@ -62,7 +62,7 @@ export default class { }) } - getPipelineGithub(pipeline: any) { + getPipelineGitHub(pipeline: any) { return this.request(`/pipelines/${pipeline}/github`, { method: 'GET', }) diff --git a/packages/cli/test/unit/commands/pipelines/connect.unit.test.ts b/packages/cli/test/unit/commands/pipelines/connect.unit.test.ts index e0eecda6d4..d240426392 100644 --- a/packages/cli/test/unit/commands/pipelines/connect.unit.test.ts +++ b/packages/cli/test/unit/commands/pipelines/connect.unit.test.ts @@ -13,7 +13,7 @@ describe('pipelines:connect', () => { .it('displays an error') }) - describe('with an account connected to Github', () => { + describe('with an account connected to GitHub', () => { test .nock('https://kolkrabbi.heroku.com', kolkrabbi => { const kolkrabbiAccount = { diff --git a/packages/cli/test/unit/commands/pipelines/diff.unit.test.ts b/packages/cli/test/unit/commands/pipelines/diff.unit.test.ts index f90735febf..ff4f702a6d 100644 --- a/packages/cli/test/unit/commands/pipelines/diff.unit.test.ts +++ b/packages/cli/test/unit/commands/pipelines/diff.unit.test.ts @@ -23,7 +23,7 @@ describe('pipelines:diff', function () { stage: 'staging', } - const targetGithubApp = { + const targetGitHubApp = { repo: 'heroku/example-app', } @@ -40,7 +40,7 @@ describe('pipelines:diff', function () { stage: 'production', } - const downstreamApp1Github = { + const downstreamApp1GitHub = { repo: 'heroku/example-app', } @@ -57,7 +57,7 @@ describe('pipelines:diff', function () { stage: 'production', } - const downstreamApp2Github = { + const downstreamApp2GitHub = { repo: 'heroku/some-other-app', } @@ -121,9 +121,9 @@ describe('pipelines:diff', function () { .nock(kolkrabbiApi, api => { api .get(`/apps/${downstreamApp1.id}/github`) - .reply(200, downstreamApp1Github) + .reply(200, downstreamApp1GitHub) .get(`/apps/${downstreamApp2.id}/github`) - .reply(200, downstreamApp2Github) + .reply(200, downstreamApp2GitHub) }) } @@ -143,7 +143,7 @@ describe('pipelines:diff', function () { .nock(kolkrabbiApi, api => { api .get(`/apps/${targetApp.id}/github`) - .reply(200, targetGithubApp) + .reply(200, targetGitHubApp) }) .command(['pipelines:diff', `--app=${targetApp.name}`]) .catch(error => { @@ -155,7 +155,7 @@ describe('pipelines:diff', function () { .nock(kolkrabbiApi, api => { api .get(`/apps/${targetApp.id}/github`) - .reply(200, targetGithubApp) + .reply(200, targetGitHubApp) }) .nock(apiUrl, api => { api @@ -180,11 +180,11 @@ describe('pipelines:diff', function () { .nock(kolkrabbiApi, api => { api .get(`/apps/${targetApp.id}/github`) - .reply(200, targetGithubApp) + .reply(200, targetGitHubApp) .get(`/apps/${downstreamApp1.id}/github`) - .reply(200, downstreamApp1Github) + .reply(200, downstreamApp1GitHub) .get(`/apps/${downstreamApp2.id}/github`) - .reply(200, downstreamApp2Github) + .reply(200, downstreamApp2GitHub) .get('/account/github/token') .reply(200, {github: {token: 'github-token'}}) }) @@ -228,7 +228,7 @@ describe('pipelines:diff', function () { }) .nock(githubApi, api => { api - .get(`/repos/${targetGithubApp.repo}/compare/${hashes[1]}...${hashes[0]}`) + .get(`/repos/${targetGitHubApp.repo}/compare/${hashes[1]}...${hashes[0]}`) .reply(404) }) .command(['pipelines:diff', `--app=${targetApp.name}`]) diff --git a/scripts/postrelease/change_management b/scripts/postrelease/change_management index 3aec992eb1..a8a957aa63 100755 --- a/scripts/postrelease/change_management +++ b/scripts/postrelease/change_management @@ -10,7 +10,7 @@ if (!isStableRelease(GITHUB_REF_TYPE, GITHUB_REF_NAME)) { const REQUEST_PROMISE = require('promise-request-retry') -// Set these in Github Actions in the heroku/cli project +// Set these in GitHub Actions in the heroku/cli project // const TPS_API_APP_ID = process.env.TPS_API_APP_ID const TPS_API_RELEASE_ACTOR_EMAIL = process.env.TPS_API_RELEASE_ACTOR_EMAIL From af9db7e0257d3fcbae46af59d87d8994d83e0855 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:29:01 -0500 Subject: [PATCH 06/12] spelling: jetbrains Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/cli/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/README.md b/packages/cli/README.md index 41fc1c6108..546185144f 100644 --- a/packages/cli/README.md +++ b/packages/cli/README.md @@ -98,7 +98,7 @@ Run one test, in this case plugin-certs-v5, with `yarn lerna run --scope @heroku ## Debugging -Using WebStorm (from Jetbrains / IntelliJ), you can run/debug an individual test case. +Using WebStorm (from JetBrains / IntelliJ), you can run/debug an individual test case. - Create a new run/debug configuration - Select the 'Mocha' type From 611ba6205d54a16611efc9050190e5ccea92ead1 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:29:11 -0500 Subject: [PATCH 07/12] spelling: latest Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/cli/test/unit/commands/ci/rerun.unit.test.ts | 2 +- packages/cli/test/unit/commands/ci/run.unit.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli/test/unit/commands/ci/rerun.unit.test.ts b/packages/cli/test/unit/commands/ci/rerun.unit.test.ts index 39dfff5727..725a085072 100644 --- a/packages/cli/test/unit/commands/ci/rerun.unit.test.ts +++ b/packages/cli/test/unit/commands/ci/rerun.unit.test.ts @@ -26,7 +26,7 @@ describe('ci:rerun', () => { } const newTestRun = { commit_branch: ghRepository.branch, - commit_message: 'lastest commit', + commit_message: 'latest commit', commit_sha: ghRepository.ref, id: 'b6512323-3a11-43ac-b4e4-9668b6a6b30c', number: 11, diff --git a/packages/cli/test/unit/commands/ci/run.unit.test.ts b/packages/cli/test/unit/commands/ci/run.unit.test.ts index e49e1694e2..56fbc33cc3 100644 --- a/packages/cli/test/unit/commands/ci/run.unit.test.ts +++ b/packages/cli/test/unit/commands/ci/run.unit.test.ts @@ -19,7 +19,7 @@ describe('ci:run', () => { } const newTestRun = { commit_branch: ghRepository.branch, - commit_message: 'lastest commit', + commit_message: 'latest commit', commit_sha: ghRepository.ref, id: 'b6512323-3a11-43ac-b4e4-9668b6a6b30c', number: 11, From 4fca79dd2765d388bfaae147f57a8458f3620dcd Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:23:40 -0500 Subject: [PATCH 08/12] spelling: macos Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- install-standalone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install-standalone.sh b/install-standalone.sh index ee216d8785..2f87e1e590 100644 --- a/install-standalone.sh +++ b/install-standalone.sh @@ -27,7 +27,7 @@ elif [ "\$(expr substr \$(uname -s) 1 5)" == "Linux" ]; then OS=linux else - echoerr "This installer is only supported on Linux and MacOS" + echoerr "This installer is only supported on Linux and macOS" exit 1 fi From 9780e8516ca002accf5e8a4d3810904c51f11f50 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:31:21 -0500 Subject: [PATCH 09/12] spelling: relax Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/ci-v5/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ci-v5/CHANGELOG.md b/packages/ci-v5/CHANGELOG.md index c4499d2046..cef385b578 100644 --- a/packages/ci-v5/CHANGELOG.md +++ b/packages/ci-v5/CHANGELOG.md @@ -860,7 +860,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/). ## [1.5.2] - 2017-04-27 ### Changed -- Releax engines requirements in package.json. +- Relax engines requirements in package.json. ## [1.5.1] - 2017-04-03 ### Changed From 1a09f3da27d81565edc7d22864c8a8e4e27f3fda Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:31:44 -0500 Subject: [PATCH 10/12] spelling: retrieve Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/cli/src/commands/autocomplete/options.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/commands/autocomplete/options.ts b/packages/cli/src/commands/autocomplete/options.ts index 117ee1fa96..9199004030 100644 --- a/packages/cli/src/commands/autocomplete/options.ts +++ b/packages/cli/src/commands/autocomplete/options.ts @@ -27,7 +27,7 @@ export default class Options extends AutocompleteBase { // *args: refers to a Command's static args // *argv: refers to the current execution's command line positional input // Klass: (class) Command class - // completion: (object) object with data/methods to build/retrive options from cache + // completion: (object) object with data/methods to build/retrieve options from cache // curPosition*: the current argv position the shell is trying to complete // options: (string) white-space separated list of values for the shell to use for completion From 9a413e27feaf19c27991792b41fd4ad53ec120b6 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:31:39 -0500 Subject: [PATCH 11/12] spelling: retrieves Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- packages/cli/test/unit/analytics.unit.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/test/unit/analytics.unit.test.ts b/packages/cli/test/unit/analytics.unit.test.ts index bb910f9e86..cf5438ac76 100644 --- a/packages/cli/test/unit/analytics.unit.test.ts +++ b/packages/cli/test/unit/analytics.unit.test.ts @@ -214,7 +214,7 @@ describe('analytics (backboard has an error) with authorizationToken', () => { user = netrc.machines[vars.apiHost]?.login || undefined }) - it('retreives user heroku API key', async () => { + it('retrieves user heroku API key', async () => { const config = await Config.load() config.platform = 'win32' config.shell = 'fish' From 0820a645623fbc2287d4cf60e6400b7190b09e77 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 18:23:47 -0500 Subject: [PATCH 12/12] spelling: typescript Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .eslintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 4db9366de9..aa3d1a8f74 100644 --- a/.eslintrc +++ b/.eslintrc @@ -46,7 +46,7 @@ "unicorn/prefer-ternary": "off" // TODO: fix issues and turn this back on }, - // Typescript settings + // TypeScript settings "overrides": [ { "files": ["**/*{.ts,tsx}"],