Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(extend/console): add jsdoc #4500

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Aug 27, 2020

What does it do?

#4136

Before we migrate Hexo to typescript, we could first bring up JSDoc. It will not only help the migration later but also provides the autocompletion for those plugin developers.

cc @septs

How to test

git clone -b jsdoc-type-extend-console https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Aug 27, 2020

Coverage Status

Coverage remained the same at 98.296% when pulling 39e9779 on SukkaW:jsdoc-type-extend-console into 08c8b23 on hexojs:master.

himself65
himself65 previously approved these changes Aug 27, 2020
* @param {String} name - The name of console plugin to be registered
* @param {String} desc - More detailed information about a console command
* @param {Option} options - The description of each option of a console command.
* @param {Function} fn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The console plugin to be registered" ?

ghost
ghost previously approved these changes Dec 22, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenjoezhang stevenjoezhang merged commit 48f6a05 into hexojs:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants