Escape HTML by default in list_tag #4743
Merged
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecape the Tag values. It should be text, not HTML This is a breaking change and documentation should be updated to explain that when using function transform, value should be escaped if needed
|
I don't know the plans for Hexo 6, but if we follow semver, we should publish this fix in Hexo 6 |
SukkaW
reviewed
Jul 22, 2021
| {source: 'foo', slug: 'foo'} | ||
| ]); | ||
|
|
||
| // TODO: Warehouse needs to add a mutex lock when writing data to avoid data sync problem |
There was a problem hiding this comment.
I just copied this part from the tests above. Not sure how to fix it
There was a problem hiding this comment.
I just add that comment to add a link back to the already opened issue (for later fix). The current workaround already looks good for this PR.
SukkaW
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escape the HTML in Tag values. It should be text, not HTML
This is a breaking change as some people might have been relying on this use case (having html in tags)
and documentation should be updated to explain that when using function transform, value should be escaped if needed